[tripleo-ha-utils] domain parameter is hard-coded inside Instance HA task

[Raoul Scarazzini]

The domain parameter needed to configure the nova-compute-checkevacuate resource [1] and the fence-nova stonith resource [2] today is hard-coded into the task as "localdomain".
Obviously, this can lead to problems when a user needs a different domain.

[1] https://github.com/openstack/tripleo-ha-utils/blob/master/roles/instance-ha/tasks/apply.yml#L252
[2] https://github.com/openstack/tripleo-ha-utils/blob/master/roles/instance-ha/tasks/apply.yml#L287

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/584364

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/584364
Committed: https://git.openstack.org/cgit/openstack/tripleo-ha-utils/commit/?id=9107b7d59cdd8d6aef81c41dbe95b13874c8a496
Submitter: Zuul
Branch: master

commit 9107b7d59cdd8d6aef81c41dbe95b13874c8a496
Author: Raoul Scarazzini <email address hidden>
Date: Fri Jul 20 14:57:17 2018 +0200

    Fix hard-coded domain in instance HA role

    This commit sets a default value of "localdomain" for the domain
    parameter related to the overcloud.
    This is used inside the role while configuring nova-compute-checkevacuate
    resource and the fence-nova STONITH device. In this way, the user will
    be able to override the default by passing the overcloud_domain
    parameter in the command line.

    Fixes-Bug: #1782752
    Change-Id: Ib76523a08e43b8d9f604e9fb2544017c9800d8a9