[tripleo-ha-utils] Instance HA task does not support stonith names for compute nodes different form ipmilan-<hostname>

[Raoul Scarazzini]

Description
===========

Instance HA playbook supports the extra var -e stonith_devices="none" in case the final user has already configured the stonith devices by himself, but this can lead to problems if the names of the stonith devices are different from what the task is expecting [1].

Steps to reproduce
==================

Pre-configure stonith devices for compute nodes naming the stonith resource differently from ipmilan-<hostname> and then launch:

$ ansible-playbook workdir/tripleo-ha-utils/playbooks/overcloud-instance-ha.yml -e release=rhos-10 -e stonith_devices="none"

Expected result
===============

Everything should work as expected since we should be able to read the name of the cluster's stonith resources dynamically.

Actual result
=============

With stonith compute names different from ipmilan-<hostname> it will likely fail

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/580725

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/580725
Committed: https://git.openstack.org/cgit/openstack/tripleo-ha-utils/commit/?id=183b16c5169d366708c9e8de479503f12482192b
Submitter: Zuul
Branch: master

commit 183b16c5169d366708c9e8de479503f12482192b
Author: Raoul Scarazzini <email address hidden>
Date: Fri Jul 6 15:21:24 2018 +0200

    Fix custom STONITH compute names in IHA playbook

    Today when STONITH for the compute nodes is already configured in the
    TripleO deployment and the name of these STONITH resources is not
    "ipmilan-<hostname>" the task will likely fail.
    This commit fixes the way STONITH levels are managed, making the task to
    not rely anymore on the fact that a user will configure also STONITH
    with the instance HA playbooks, but reading dynamically the name of the
    resources.
    It also takes care about it while removing the IHA steps, preserving the
    idempotent principle.

    Closes-Bug: #1780434

    Change-Id: I2f8351cf62cddd420c257110d60442ca4243a43d