tripleo

image-serve sends the wrong tag metadata for some tags

Bug #1953198 reported by Alex Schultz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Alex Schultz
tripleo yoga-1

Bug Description

With the image-serve if you have two tags where one is a subset of another (e.g 16.1 and 16.1.4) the wrong metadata may be returned for the shorter tag. For example if you wanted the 16.1 tag metadata, the 16.1.4 tag metadata is returned. This is due to the MultiviewsMatch configuration where it will look for "16.1*" in an attempt to find the file. Unfortunately 16.1.4.type-map is returned before 16.1.type-map which causes the wrong metadata to be returned.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ansible (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-ansible/+/820404

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-common (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-common/+/820405

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ansible (master)

Reviewed: https://review.opendev.org/c/openstack/tripleo-ansible/+/820404
Committed: https://opendev.org/openstack/tripleo-ansible/commit/419f3166a31f1f13d7ca64815bd093bd0df45351
Submitter: "Zuul (22348)"
Branch: master

commit 419f3166a31f1f13d7ca64815bd093bd0df45351
Author: Alex Schultz <email address hidden>
Date: Fri Dec 3 13:15:56 2021 -0700

    Disable image-serve MultiViews

    The MultiViews configuration for manifests is causing the wrong
    manifest data being returned for some tags. This change removes the
    MultiViews configuration and moves the configuration we used to put into
    an .htaccess file into the image serve apache configuration. The
    manifest requests should no longer trigger the .htaccess configuration
    but the .htaccess for the actual metadata file should still be returned
    with this change.

    Change-Id: Ifd86b50e308bca0b8fd4ddb870b289dde8dbe046
    Closes-Bug: #1953198

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-common (master)

Reviewed: https://review.opendev.org/c/openstack/tripleo-common/+/820405
Committed: https://opendev.org/openstack/tripleo-common/commit/6a34b52982f3d4d004f4dff30cd9ff4aeb33129b
Submitter: "Zuul (22348)"
Branch: master

commit 6a34b52982f3d4d004f4dff30cd9ff4aeb33129b
Author: Alex Schultz <email address hidden>
Date: Fri Dec 3 13:26:23 2021 -0700

    Stop creating manifest .htaccess

    This is no longer needed as this isn't dynamic so we can moved it to the
    image-server httpd configuration. Additionally MultiviewsMatch is
    causing problems so we don't want that anymore. This file will be
    ignored with the updated configuration so this just stops it from being
    created going forward.

    Depends-On: https://review.opendev.org/c/openstack/tripleo-ansible/+/820404
    Change-Id: I307be36cfdd26510bbe5b48365d6c04881f61d1f
    Related-Bug: #1953198

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ansible (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-ansible/+/820507

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-common (stable/wallaby)

Related fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-common/+/820508

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ansible (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/tripleo-ansible/+/820509

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ansible (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/tripleo-ansible/+/820610

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ansible (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/tripleo-ansible/+/820594

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ansible (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/tripleo-ansible/+/820509
Committed: https://opendev.org/openstack/tripleo-ansible/commit/eb4c66e1eb3bc92ffa0809df6d508f880809e496
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit eb4c66e1eb3bc92ffa0809df6d508f880809e496
Author: Alex Schultz <email address hidden>
Date: Fri Dec 3 13:15:56 2021 -0700

    Disable image-serve MultiViews

    The MultiViews configuration for manifests is causing the wrong
    manifest data being returned for some tags. This change removes the
    MultiViews configuration and moves the configuration we used to put into
    an .htaccess file into the image serve apache configuration. The
    manifest requests should no longer trigger the .htaccess configuration
    but the .htaccess for the actual metadata file should still be returned
    with this change.

    Change-Id: Ifd86b50e308bca0b8fd4ddb870b289dde8dbe046
    Closes-Bug: #1953198
    (cherry picked from commit 419f3166a31f1f13d7ca64815bd093bd0df45351)

tags: added: in-stable-victoria
tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ansible (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/tripleo-ansible/+/820610
Committed: https://opendev.org/openstack/tripleo-ansible/commit/213ff80604de0e5c047b44857acdf685fa89c3f8
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 213ff80604de0e5c047b44857acdf685fa89c3f8
Author: Alex Schultz <email address hidden>
Date: Fri Dec 3 13:15:56 2021 -0700

    Disable image-serve MultiViews

    The MultiViews configuration for manifests is causing the wrong
    manifest data being returned for some tags. This change removes the
    MultiViews configuration and moves the configuration we used to put into
    an .htaccess file into the image serve apache configuration. The
    manifest requests should no longer trigger the .htaccess configuration
    but the .htaccess for the actual metadata file should still be returned
    with this change.

    Change-Id: Ifd86b50e308bca0b8fd4ddb870b289dde8dbe046
    Closes-Bug: #1953198
    (cherry picked from commit 419f3166a31f1f13d7ca64815bd093bd0df45351)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ansible (stable/train)

Reviewed: https://review.opendev.org/c/openstack/tripleo-ansible/+/820594
Committed: https://opendev.org/openstack/tripleo-ansible/commit/0290622036008c39c3d76e3063128c61f2967db5
Submitter: "Zuul (22348)"
Branch: stable/train

commit 0290622036008c39c3d76e3063128c61f2967db5
Author: Alex Schultz <email address hidden>
Date: Fri Dec 3 13:15:56 2021 -0700

    Disable image-serve MultiViews

    The MultiViews configuration for manifests is causing the wrong
    manifest data being returned for some tags. This change removes the
    MultiViews configuration and moves the configuration we used to put into
    an .htaccess file into the image serve apache configuration. The
    manifest requests should no longer trigger the .htaccess configuration
    but the .htaccess for the actual metadata file should still be returned
    with this change.

    Change-Id: Ifd86b50e308bca0b8fd4ddb870b289dde8dbe046
    Closes-Bug: #1953198
    (cherry picked from commit 419f3166a31f1f13d7ca64815bd093bd0df45351)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ansible (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/tripleo-ansible/+/820507
Committed: https://opendev.org/openstack/tripleo-ansible/commit/538ee47d2821ce843da7a39da6beb3b814b47f60
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 538ee47d2821ce843da7a39da6beb3b814b47f60
Author: Alex Schultz <email address hidden>
Date: Fri Dec 3 13:15:56 2021 -0700

    Disable image-serve MultiViews

    The MultiViews configuration for manifests is causing the wrong
    manifest data being returned for some tags. This change removes the
    MultiViews configuration and moves the configuration we used to put into
    an .htaccess file into the image serve apache configuration. The
    manifest requests should no longer trigger the .htaccess configuration
    but the .htaccess for the actual metadata file should still be returned
    with this change.

    Change-Id: Ifd86b50e308bca0b8fd4ddb870b289dde8dbe046
    Closes-Bug: #1953198
    (cherry picked from commit 419f3166a31f1f13d7ca64815bd093bd0df45351)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-common (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/tripleo-common/+/820508
Committed: https://opendev.org/openstack/tripleo-common/commit/13f12708d477e005b98b94a153bbd68ef61298ab
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 13f12708d477e005b98b94a153bbd68ef61298ab
Author: Alex Schultz <email address hidden>
Date: Fri Dec 3 13:26:23 2021 -0700

    Stop creating manifest .htaccess

    This is no longer needed as this isn't dynamic so we can moved it to the
    image-server httpd configuration. Additionally MultiviewsMatch is
    causing problems so we don't want that anymore. This file will be
    ignored with the updated configuration so this just stops it from being
    created going forward.

    Depends-On: https://review.opendev.org/c/openstack/tripleo-ansible/+/820507
    Change-Id: I307be36cfdd26510bbe5b48365d6c04881f61d1f
    Related-Bug: #1953198
    (cherry picked from commit 6a34b52982f3d4d004f4dff30cd9ff4aeb33129b)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-ansible 1.5.6

This issue was fixed in the openstack/tripleo-ansible 1.5.6 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-ansible 4.2.0

This issue was fixed in the openstack/tripleo-ansible 4.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-ansible 2.6.0

This issue was fixed in the openstack/tripleo-ansible 2.6.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-ansible train-eol

This issue was fixed in the openstack/tripleo-ansible train-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.