containers without a namespace are not correctly added to the catalog initially

[Alex Schultz]

When you upload a container with out a namespace (e.g. undercloud:8787/foo:latest) to the undercloud image-serve, the container is not being correctly added to the catalog. It will get updated later if you run something like `openstack tripleo container image delete` on a different container. This is caused by the build_catalog() function being called too early before all the metadata has been created.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-common/+/817288

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-common/+/817288
Committed: https://opendev.org/openstack/tripleo-common/commit/f8eeb0dd834ecd0faae05161cef4a38211894a7a
Submitter: "Zuul (22348)"
Branch: master

commit f8eeb0dd834ecd0faae05161cef4a38211894a7a
Author: Alex Schultz <email address hidden>
Date: Tue Nov 9 11:04:55 2021 -0700

    Fix namespace-less containers in image-serve

    The build_catalog() function expects the manifests, tags and blobs be
    available before the catalog will recognized a container image. The
    previous spot where this function was called was after the manifests but
    before the tags are created. This causes the newly uploaded container
    not to be listed in the catalog. This change moves the build_catalog()
    to last so new images get correctly added to the catalog.

    Change-Id: I3f08fe0efef1e830b034fab06574a05dff89ccc0
    Closes-Bug: #1950352

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-common/+/817422

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/tripleo-common/+/817423

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/tripleo-common/+/817424

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/tripleo-common/+/817425

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-common/+/817422
Committed: https://opendev.org/openstack/tripleo-common/commit/7f4565de7f0b202ee07a4861da599c47468ff008
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 7f4565de7f0b202ee07a4861da599c47468ff008
Author: Alex Schultz <email address hidden>
Date: Tue Nov 9 11:04:55 2021 -0700

    Fix namespace-less containers in image-serve

    The build_catalog() function expects the manifests, tags and blobs be
    available before the catalog will recognized a container image. The
    previous spot where this function was called was after the manifests but
    before the tags are created. This causes the newly uploaded container
    not to be listed in the catalog. This change moves the build_catalog()
    to last so new images get correctly added to the catalog.

    Change-Id: I3f08fe0efef1e830b034fab06574a05dff89ccc0
    Closes-Bug: #1950352
    (cherry picked from commit f8eeb0dd834ecd0faae05161cef4a38211894a7a)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-common/+/817424
Committed: https://opendev.org/openstack/tripleo-common/commit/9e10876bd8c8daca6c656ab96571cc9b64ab54cc
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 9e10876bd8c8daca6c656ab96571cc9b64ab54cc
Author: Alex Schultz <email address hidden>
Date: Tue Nov 9 11:04:55 2021 -0700

    Fix namespace-less containers in image-serve

    The build_catalog() function expects the manifests, tags and blobs be
    available before the catalog will recognized a container image. The
    previous spot where this function was called was after the manifests but
    before the tags are created. This causes the newly uploaded container
    not to be listed in the catalog. This change moves the build_catalog()
    to last so new images get correctly added to the catalog.

    Change-Id: I3f08fe0efef1e830b034fab06574a05dff89ccc0
    Closes-Bug: #1950352
    (cherry picked from commit f8eeb0dd834ecd0faae05161cef4a38211894a7a)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-common/+/817425
Committed: https://opendev.org/openstack/tripleo-common/commit/238def5e4ffd6ad576b5be4fa386fb07e64e60d8
Submitter: "Zuul (22348)"
Branch: stable/train

commit 238def5e4ffd6ad576b5be4fa386fb07e64e60d8
Author: Alex Schultz <email address hidden>
Date: Tue Nov 9 11:04:55 2021 -0700

    Fix namespace-less containers in image-serve

    The build_catalog() function expects the manifests, tags and blobs be
    available before the catalog will recognized a container image. The
    previous spot where this function was called was after the manifests but
    before the tags are created. This causes the newly uploaded container
    not to be listed in the catalog. This change moves the build_catalog()
    to last so new images get correctly added to the catalog.

    Change-Id: I3f08fe0efef1e830b034fab06574a05dff89ccc0
    Closes-Bug: #1950352
    (cherry picked from commit f8eeb0dd834ecd0faae05161cef4a38211894a7a)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-common/+/817423
Committed: https://opendev.org/openstack/tripleo-common/commit/163d4b7239276f8a97b36d1d1e963111fa8faf0d
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 163d4b7239276f8a97b36d1d1e963111fa8faf0d
Author: Alex Schultz <email address hidden>
Date: Tue Nov 9 11:04:55 2021 -0700

    Fix namespace-less containers in image-serve

    The build_catalog() function expects the manifests, tags and blobs be
    available before the catalog will recognized a container image. The
    previous spot where this function was called was after the manifests but
    before the tags are created. This causes the newly uploaded container
    not to be listed in the catalog. This change moves the build_catalog()
    to last so new images get correctly added to the catalog.

    Change-Id: I3f08fe0efef1e830b034fab06574a05dff89ccc0
    Closes-Bug: #1950352
    (cherry picked from commit f8eeb0dd834ecd0faae05161cef4a38211894a7a)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 16.3.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 12.4.7 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 13.3.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common train-eol release.