config-download Timeout Does Not Always Work

[Luke Short]

Description
===========
The `openstack overcloud deploy --config-download-timeout` argument does not always timeout the ansible-playbook command it runs.

Steps to reproduce
==================
Deploy a large scale Overcloud deployment with the argument`--config-download-timeout 30` and Ceph enabled.

Expected result
===============
config-download and all of it's child processes should be killed immediately after the timeout.

Actual result
=============
The ansible-playbook command and it's child processes continue to run.

Environment
===========
Affects all releases.

Logs & Configs
==============
Relevant logs can be found here: https://bugzilla.redhat.com/show_bug.cgi?id=1801502

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/713707

[Bogdan Dobrelya (bogdando)]

also related https://bugs.launchpad.net/tripleo/+bug/1868063

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/713707
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=7be36f305107c0bfb4e403f5df4226635e34dffa
Submitter: Zuul
Branch: master

commit 7be36f305107c0bfb4e403f5df4226635e34dffa
Author: Luke Short <email address hidden>
Date: Wed Mar 18 14:03:34 2020 -0400

    config-download timeout should KILL the process.

    The timeout command defaults to using TERM which does
    not always ensure that it will end soon enough. The
    ansible-playbook command should end as soon as possible.

    Change-Id: I0f97772434040f04f9495239b9a432c1ac062555
    Closes-Bug: #1867968
    Signed-off-by: Luke Short <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/714659

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/715956

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/715959

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/714659
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=9faf10dd844b13d002b0d16413935fceae46ed4e
Submitter: Zuul
Branch: stable/train

commit 9faf10dd844b13d002b0d16413935fceae46ed4e
Author: Luke Short <email address hidden>
Date: Wed Mar 18 14:03:34 2020 -0400

    config-download timeout should KILL the process.

    The timeout command defaults to using TERM which does
    not always ensure that it will end soon enough. The
    ansible-playbook command should end as soon as possible.

    Change-Id: I0f97772434040f04f9495239b9a432c1ac062555
    Closes-Bug: #1867968
    Signed-off-by: Luke Short <email address hidden>
    (cherry picked from commit 7be36f305107c0bfb4e403f5df4226635e34dffa)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/715956
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=c9cced6131113a0946f5a0ccd676b60b7ed0bcb6
Submitter: Zuul
Branch: stable/stein

commit c9cced6131113a0946f5a0ccd676b60b7ed0bcb6
Author: Luke Short <email address hidden>
Date: Wed Mar 18 14:03:34 2020 -0400

    config-download timeout should KILL the process.

    The timeout command defaults to using TERM which does
    not always ensure that it will end soon enough. The
    ansible-playbook command should end as soon as possible.

    Change-Id: I0f97772434040f04f9495239b9a432c1ac062555
    Closes-Bug: #1867968
    Signed-off-by: Luke Short <email address hidden>
    (cherry picked from commit 7be36f305107c0bfb4e403f5df4226635e34dffa)
    (cherry picked from commit 9faf10dd844b13d002b0d16413935fceae46ed4e)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/715959
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=d1bb0e6c32f46fdc3012a34842fbfbd1bdfa2cde
Submitter: Zuul
Branch: stable/rocky

commit d1bb0e6c32f46fdc3012a34842fbfbd1bdfa2cde
Author: Luke Short <email address hidden>
Date: Wed Mar 18 14:03:34 2020 -0400

    config-download timeout should KILL the process.

    The timeout command defaults to using TERM which does
    not always ensure that it will end soon enough. The
    ansible-playbook command should end as soon as possible.

    Change-Id: I0f97772434040f04f9495239b9a432c1ac062555
    Closes-Bug: #1867968
    Signed-off-by: Luke Short <email address hidden>
    (cherry picked from commit 7be36f305107c0bfb4e403f5df4226635e34dffa)
    (cherry picked from commit 9faf10dd844b13d002b0d16413935fceae46ed4e)
    (cherry picked from commit c9cced6131113a0946f5a0ccd676b60b7ed0bcb6)

[Bogdan Dobrelya (bogdando)]

See also https://bugs.launchpad.net/tripleo/+bug/1868063

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 12.3.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common rocky-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common stein-eol release.