ceph-ansible fetch directory management is no longer necessary

[John Fulton]

As of ceph-ansible 4.0.14-1 it is no longer necessary to have a fetch directory to replace a ceph monitor on any openstack node (e.g. on the Controllers). Thus, the fetch directory management code should be removed as it wastes cycles and could cause bugs.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/709249

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/709250

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/709251

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/709249
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=a54dc49bba9b31cf16416f6478d0f784b6503a9a
Submitter: Zuul
Branch: master

commit a54dc49bba9b31cf16416f6478d0f784b6503a9a
Author: John Fulton <email address hidden>
Date: Fri Feb 21 21:24:10 2020 +0000

    Do not create temporary swift URLS for ceph-ansible

    The state information in the ceph-ansible fetch directory
    is no longer necessary to replace a Ceph monitor as of
    ceph-ansible 4.0.14-1. Stein, Train, Ussuri and newer
    should be using this version of ceph-ansible or newer.
    TripleO does not need to do extra work to maintain the
    fetch directory.

    This means that the plan_management workbook no longer
    needs to create the SwiftFetchDirGetTempurl and the
    SwiftFetchDirPutTempurl parameters. This patch removes
    the create_ceph_ansible_fetch_directory_backup_plan
    task which creates them. It also removes the workbook
    rename_ceph_ansible_fetch_directory.

    Both Icce658f803a608ee4b7df34b0b8297ecabcdb0ee and
    Ifab82c9a5b0a206c14ae7976d2c1c7f0e9fa3d9d are effectively
    reverted of their ceph aspects with this change, but this
    change should not be backported to Rocky or older because
    ceph-ansible 3 still needs the fetch directory.

    Change-Id: I167449e4d7e38f0f5fd74251a3bd8f5b0b31451b
    Related-Bug: #1863809

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/709251
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=b656f523cfc4c486dd99fcb16d7d898e2603b913
Submitter: Zuul
Branch: master

commit b656f523cfc4c486dd99fcb16d7d898e2603b913
Author: John Fulton <email address hidden>
Date: Fri Feb 21 20:56:37 2020 +0000

    Remove support for ceph-ansible fetch directory

    The state information in the ceph-ansible fetch directory
    is no longer necessary to replace a Ceph monitor as of
    ceph-ansible 4.0.14-1. Stein, Train, Ussuri and newer
    should be using this version of ceph-ansible or newer.
    TripleO does not need to do extra work to maintain the
    fetch directory.

    Add SwiftFetchDirGetTempurl, SwiftFetchDirPutTempurl, and
    LocalCephAnsibleFetchDirectoryBackup to the deprecated list
    of parameters and modify code to not use these parameters.
    Remove call to tripleo-ansible/tripleo_ceph_fetch_dir role.

    Update tripleo-common/workbooks/plan_management.yaml to not
    create SwiftFetchDirGetTempurl and SwiftFetchDirPutTempurl
    during deployment and update via depends-on patch.

    Depends-On: I167449e4d7e38f0f5fd74251a3bd8f5b0b31451b
    Change-Id: I3f8c2571a6dd35029d71dd42df637a962d9b3235
    Closes-bug: #1863809

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/709250
Committed: https://git.openstack.org/cgit/openstack/tripleo-ansible/commit/?id=f3c8c59fe0bf11108a23f2bcecf9e44db41fb3ce
Submitter: Zuul
Branch: master

commit f3c8c59fe0bf11108a23f2bcecf9e44db41fb3ce
Author: John Fulton <email address hidden>
Date: Fri Feb 21 21:48:00 2020 +0000

    Remove tripleo_ceph_fetch_dir role

    The state information in the ceph-ansible fetch directory
    is no longer necessary to replace a Ceph monitor as of
    ceph-ansible 4.0.14-1. Stein, Train, Ussuri and newer
    should be using this version of ceph-ansible or newer.
    TripleO does not need to do extra work to maintain the
    fetch directory. Remove tripleo_ceph_fetch_dir role and
    modify code flow so that it's no longer used.

    Also, remove unnecessary dependencies in tripleo-ceph-*
    roles as described in LP #1844837.

    Change-Id: Ic292dcc1bcf1e7575285ad56d56df2966e968b6d
    Depends-On: I3f8c2571a6dd35029d71dd42df637a962d9b3235
    Related-Bug: #1863809
    Closes-Bug: #1844837

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/train
Review: https://review.opendev.org/710647

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/710648

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/train
Review: https://review.opendev.org/710651

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/710647
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=5b363038a2329cde1cd60dbcae610b196346d714
Submitter: Zuul
Branch: stable/train

commit 5b363038a2329cde1cd60dbcae610b196346d714
Author: John Fulton <email address hidden>
Date: Fri Feb 21 21:24:10 2020 +0000

    Do not create temporary swift URLS for ceph-ansible

    The state information in the ceph-ansible fetch directory
    is no longer necessary to replace a Ceph monitor as of
    ceph-ansible 4.0.14-1. Stein, Train, Ussuri and newer
    should be using this version of ceph-ansible or newer.
    TripleO does not need to do extra work to maintain the
    fetch directory.

    This means that the plan_management workbook no longer
    needs to create the SwiftFetchDirGetTempurl and the
    SwiftFetchDirPutTempurl parameters. This patch removes
    the create_ceph_ansible_fetch_directory_backup_plan
    task which creates them. It also removes the workbook
    rename_ceph_ansible_fetch_directory.

    Both Icce658f803a608ee4b7df34b0b8297ecabcdb0ee and
    Ifab82c9a5b0a206c14ae7976d2c1c7f0e9fa3d9d are effectively
    reverted of their ceph aspects with this change, but this
    change should not be backported to Rocky or older because
    ceph-ansible 3 still needs the fetch directory.

    Unlclean cherry pick; required manual changes.

    Change-Id: I167449e4d7e38f0f5fd74251a3bd8f5b0b31451b
    Related-Bug: #1863809
    (cherry picked from commit a54dc49bba9b31cf16416f6478d0f784b6503a9a)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/710648
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=5ac7a8c49831b7b3b45b565c0be665605b919e2c
Submitter: Zuul
Branch: stable/train

commit 5ac7a8c49831b7b3b45b565c0be665605b919e2c
Author: John Fulton <email address hidden>
Date: Fri Feb 21 20:56:37 2020 +0000

    Remove support for ceph-ansible fetch directory

    The state information in the ceph-ansible fetch directory
    is no longer necessary to replace a Ceph monitor as of
    ceph-ansible 4.0.14-1. Stein, Train, Ussuri and newer
    should be using this version of ceph-ansible or newer.
    TripleO does not need to do extra work to maintain the
    fetch directory.

    Add SwiftFetchDirGetTempurl, SwiftFetchDirPutTempurl, and
    LocalCephAnsibleFetchDirectoryBackup to the deprecated list
    of parameters and modify code to not use these parameters.
    Remove call to tripleo-ansible/tripleo_ceph_fetch_dir role.

    Update tripleo-common/workbooks/plan_management.yaml to not
    create SwiftFetchDirGetTempurl and SwiftFetchDirPutTempurl
    during deployment and update via depends-on patch.

    Unlclean cherry pick; required manual changes.

    Depends-On: I167449e4d7e38f0f5fd74251a3bd8f5b0b31451b
    Change-Id: I3f8c2571a6dd35029d71dd42df637a962d9b3235
    Closes-bug: #1863809
    Closes-Bug: #1865357
    (cherry picked from commit b656f523cfc4c486dd99fcb16d7d898e2603b913)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/710651
Committed: https://git.openstack.org/cgit/openstack/tripleo-ansible/commit/?id=ed21e70f76be2760c168dc6811a834780da2c718
Submitter: Zuul
Branch: stable/train

commit ed21e70f76be2760c168dc6811a834780da2c718
Author: John Fulton <email address hidden>
Date: Fri Feb 21 21:48:00 2020 +0000

    Remove tripleo_ceph_fetch_dir role

    The state information in the ceph-ansible fetch directory
    is no longer necessary to replace a Ceph monitor as of
    ceph-ansible 4.0.14-1. Stein, Train, Ussuri and newer
    should be using this version of ceph-ansible or newer.
    TripleO does not need to do extra work to maintain the
    fetch directory. Remove tripleo_ceph_fetch_dir role and
    modify code flow so that it's no longer used.

    Also, remove unnecessary dependencies in tripleo-ceph-*
    roles as described in LP #1844837.

    Unlclean cherry pick; required manual changes

    Change-Id: Ic292dcc1bcf1e7575285ad56d56df2966e968b6d
    Depends-On: I3f8c2571a6dd35029d71dd42df637a962d9b3235
    Related-Bug: #1863809
    Closes-Bug: #1844837
    (cherry picked from commit f3c8c59fe0bf11108a23f2bcecf9e44db41fb3ce)

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/stein
Review: https://review.opendev.org/711000

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/711004

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/711000
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=a6d1b7dd9a3ecf482be48f40bd257a1e3ca3d7e5
Submitter: Zuul
Branch: stable/stein

commit a6d1b7dd9a3ecf482be48f40bd257a1e3ca3d7e5
Author: John Fulton <email address hidden>
Date: Fri Feb 21 21:24:10 2020 +0000

    Do not create temporary swift URLS for ceph-ansible

    The state information in the ceph-ansible fetch directory
    is no longer necessary to replace a Ceph monitor as of
    ceph-ansible 4.0.14-1. Stein, Train, Ussuri and newer
    should be using this version of ceph-ansible or newer.
    TripleO does not need to do extra work to maintain the
    fetch directory.

    This means that the plan_management workbook no longer
    needs to create the SwiftFetchDirGetTempurl and the
    SwiftFetchDirPutTempurl parameters. This patch removes
    the create_ceph_ansible_fetch_directory_backup_plan
    task which creates them. It also removes the workbook
    rename_ceph_ansible_fetch_directory.

    Both Icce658f803a608ee4b7df34b0b8297ecabcdb0ee and
    Ifab82c9a5b0a206c14ae7976d2c1c7f0e9fa3d9d are effectively
    reverted of their ceph aspects with this change, but this
    change should not be backported to Rocky or older because
    ceph-ansible 3 still needs the fetch directory.

    Unlclean cherry pick; required manual changes.

    Change-Id: I167449e4d7e38f0f5fd74251a3bd8f5b0b31451b
    Related-Bug: #1863809
    (cherry picked from commit a54dc49bba9b31cf16416f6478d0f784b6503a9a)
    (cherry picked from commit 5b363038a2329cde1cd60dbcae610b196346d714)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/711004
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=16d21b6c687b42e875838b08fe15612f0481b06b
Submitter: Zuul
Branch: stable/stein

commit 16d21b6c687b42e875838b08fe15612f0481b06b
Author: John Fulton <email address hidden>
Date: Fri Feb 21 20:56:37 2020 +0000

    Remove support for ceph-ansible fetch directory

    The state information in the ceph-ansible fetch directory
    is no longer necessary to replace a Ceph monitor as of
    ceph-ansible 4.0.14-1. Stein, Train, Ussuri and newer
    should be using this version of ceph-ansible or newer.
    TripleO does not need to do extra work to maintain the
    fetch directory.

    Add SwiftFetchDirGetTempurl, SwiftFetchDirPutTempurl, and
    LocalCephAnsibleFetchDirectoryBackup to the deprecated list
    of parameters and modify code to not use these parameters.
    Remove call to tripleo-ansible/tripleo_ceph_fetch_dir role.

    Update tripleo-common/workbooks/plan_management.yaml to not
    create SwiftFetchDirGetTempurl and SwiftFetchDirPutTempurl
    during deployment and update via depends-on patch.

    Unlclean cherry pick; required manual changes.

    Depends-On: I167449e4d7e38f0f5fd74251a3bd8f5b0b31451b
    Change-Id: I3f8c2571a6dd35029d71dd42df637a962d9b3235
    Closes-bug: #1863809
    Closes-Bug: #1865357
    (cherry picked from commit b656f523cfc4c486dd99fcb16d7d898e2603b913)
    (cherry picked from commit 5ac7a8c49831b7b3b45b565c0be665605b919e2c)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 12.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 11.4.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates stein-eol release.