tripleo

Ceph FSID generated by TripleO client could be more random

Bug #1856762 reported by John Fulton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Low
John Fulton
tripleo ussuri-2 "tripleo ussuri-2"

Bug Description

The CephClusterFSID generated when TripleO deploys Ceph (by passing the desired FSID to ceph-ansible) uses Python's uuid1() [1]. It could be more random however and be generated by Python's uuid4().

[1] https://docs.python.org/3/library/uuid.html#uuid.uuid1

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (master)

Fix proposed to branch: master
Review: https://review.opendev.org/699505

Changed in tripleo:
status: Triaged → In Progress
Emilien Macchi (emilienm)
Changed in tripleo:
milestone: ussuri-1 → ussuri-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (master)

Reviewed: https://review.opendev.org/699505
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=90584a801a077a2c64f582523628876c388ccbe2
Submitter: Zuul
Branch: master

commit 90584a801a077a2c64f582523628876c388ccbe2
Author: John Fulton <email address hidden>
Date: Tue Dec 17 16:47:22 2019 -0500

    Increase randomness of generated CephFSID

    Switch from uuid1() to uuid4() so that the resulting
    UUID is more random because getnode() is not used.

    Change-Id: I611efb6ef5b6e899e3223ecb698e331ed6326c3b
    Closes-Bug: #1856762

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 12.1.0

This issue was fixed in the openstack/tripleo-common 12.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/712099

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (stable/train)

Reviewed: https://review.opendev.org/712099
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=89f84051b26ce49bc4086f88c50669c82bc66f9b
Submitter: Zuul
Branch: stable/train

commit 89f84051b26ce49bc4086f88c50669c82bc66f9b
Author: John Fulton <email address hidden>
Date: Tue Dec 17 16:47:22 2019 -0500

    Increase randomness of generated CephFSID

    Switch from uuid1() to uuid4() so that the resulting
    UUID is more random because getnode() is not used.

    Change-Id: I611efb6ef5b6e899e3223ecb698e331ed6326c3b
    Closes-Bug: #1856762
    (cherry picked from commit 90584a801a077a2c64f582523628876c388ccbe2)

tags: added: in-stable-train
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.