/var/lib/mistral/<stackname> directory is removed at the end of a scaledown

[Cédric Jeanneret]

Description of problem:
The /var/lib/mistral/<overcloud stack name> directory is dropped when a scaledown is over. This prevent any debugging.

It might be within tripleo-common or tripleoclient - not really sure about the component.

Version-Release number of selected component (if applicable):
openstack-tripleo-common-containers-11.3.2-0.20191127200418.5c82293.el8ost.noarch
python3-tripleo-common-11.3.2-0.20191127200418.5c82293.el8ost.noarch
openstack-tripleo-common-11.3.2-0.20191127200418.5c82293.el8ost.noarch
python3-tripleoclient-12.3.1-0.20191202211445.46c5fb4.el8ost.noarch

How reproducible:
Always

Steps to Reproduce:
1. Deploy Director + Overcloud
2. Remove an overcloud node (Compute for instance)
3. Check the existence of /var/lib/mistral/<overcloud stack name>

Actual results:
The directory is removed at some point

Expected results:
The directory should be there

This is also known as rhbz https://bugzilla.redhat.com/show_bug.cgi?id=1782379

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/698709

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/698709
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=33417a43aa01bf9ef0fceb6c6cc16e3dfc6e286b
Submitter: Zuul
Branch: master

commit 33417a43aa01bf9ef0fceb6c6cc16e3dfc6e286b
Author: Cédric Jeanneret <email address hidden>
Date: Thu Dec 12 12:01:33 2019 +0100

    Remove workdir only if it's a temporary one

    Up to now, in some cases, you might see the "persistent" workdir being
    removed, for instance after a scale-down run.

    This patch intends to drop only temporary workdirs, so that we shouldn't
    see the /var/lib/mistral/<stackname> disapearing.

    Change-Id: I4516648c9281becffe8f31b76db22da84caf3ca8
    Co-Authored-By: "Dougal Matthews <email address hidden>"
    Closes-Bug: #1856061

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/699007

[OpenStack Infra (hudson-openstack)]

Change abandoned by Emilien Macchi (<email address hidden>) on branch: stable/train
Review: https://review.opendev.org/699007
Reason: Clearing the gate now, see https://bugs.launchpad.net/tripleo/+bug/1856864
Do not restore the patch yet, I'll take care of it when the gate is back online.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/699007
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=94a8ce483311db85dc30ce490148ce726bc143ee
Submitter: Zuul
Branch: stable/train

commit 94a8ce483311db85dc30ce490148ce726bc143ee
Author: Cédric Jeanneret <email address hidden>
Date: Thu Dec 12 12:01:33 2019 +0100

    Remove workdir only if it's a temporary one

    Up to now, in some cases, you might see the "persistent" workdir being
    removed, for instance after a scale-down run.

    This patch intends to drop only temporary workdirs, so that we shouldn't
    see the /var/lib/mistral/<stackname> disapearing.

    Change-Id: I4516648c9281becffe8f31b76db22da84caf3ca8
    Co-Authored-By: "Dougal Matthews <email address hidden>"
    Closes-Bug: #1856061
    (cherry picked from commit 33417a43aa01bf9ef0fceb6c6cc16e3dfc6e286b)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 11.3.2 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 12.1.0 release.