JSON Query cannot parse invalid characters

[Luke Short]

Using a customized post-deploy.yaml can lead to an error with config-download deployment/update/upgrade. The json_query detects "-" as a negative number and also issues parsing other characters as well. This problem affects the Queens release and newer.

TASK [Lookup deployment UUID] **************************************************
Thursday 31 October 2019 16:13:58 +0300 (0:00:00.536) 0:30:41.357 ******
fatal: [cauqctr02]: FAILED! => {"msg": "JMESPathError in json_query filter plugin:\nUnexpected token: -2: Parse error at column 16, token \"-2\" (NUMBER), for expression:\n\"ExtraDeployments-2.id\"\n ^"}
fatal: [cauqctr03]: FAILED! => {"msg": "JMESPathError in json_query filter plugin:\nUnexpected token: -2: Parse error at column 16, token \"-2\" (NUMBER), for expression:\n\"ExtraDeployments-2.id\"\n ^"}
fatal: [cauqctr01]: FAILED! => {"msg": "JMESPathError in json_query filter plugin:\nUnexpected token: -2: Parse error at column 16, token \"-2\" (NUMBER), for expression:\n\"ExtraDeployments-2.id\"\n ^"}

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/693910
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=e028953d0b1507f0c048bddf0d5cedab69f4bfbe
Submitter: Zuul
Branch: master

commit e028953d0b1507f0c048bddf0d5cedab69f4bfbe
Author: Luke Short <email address hidden>
Date: Tue Nov 12 14:17:52 2019 -0500

    Escape invalid JSON characters during deployment.

    By first quoting the JSON query, it is possible to easily pass
    it to the json_query plugin. This allows elements with special
    characters, such as a hyphen -, to be resolvable.

    Change-Id: I56f3e5f96dc25f16aed585ca6678de53721071b7
    Closes-Bug: #1853321
    Signed-off-by: Luke Short <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/695746

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/695747

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/695749

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/695750

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/695746
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=7cebd8b3e1100890ff6d6ec82922cac608055e7d
Submitter: Zuul
Branch: stable/train

commit 7cebd8b3e1100890ff6d6ec82922cac608055e7d
Author: Luke Short <email address hidden>
Date: Tue Nov 12 14:17:52 2019 -0500

    Escape invalid JSON characters during deployment.

    By first quoting the JSON query, it is possible to easily pass
    it to the json_query plugin. This allows elements with special
    characters, such as a hyphen -, to be resolvable.

    Change-Id: I56f3e5f96dc25f16aed585ca6678de53721071b7
    Closes-Bug: #1853321
    Signed-off-by: Luke Short <email address hidden>
    (cherry picked from commit e028953d0b1507f0c048bddf0d5cedab69f4bfbe)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/695747
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=c2a83c1cd5e8cc9cb04432e9bc8f37793c02f0c7
Submitter: Zuul
Branch: stable/stein

commit c2a83c1cd5e8cc9cb04432e9bc8f37793c02f0c7
Author: Luke Short <email address hidden>
Date: Tue Nov 12 14:17:52 2019 -0500

    Escape invalid JSON characters during deployment.

    By first quoting the JSON query, it is possible to easily pass
    it to the json_query plugin. This allows elements with special
    characters, such as a hyphen -, to be resolvable.

    Conflicts:
        tripleo_common/templates/deployments.yaml

    Change-Id: I56f3e5f96dc25f16aed585ca6678de53721071b7
    Closes-Bug: #1853321
    Signed-off-by: Luke Short <email address hidden>
    (cherry picked from commit 7cebd8b3e1100890ff6d6ec82922cac608055e7d)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/695749
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=f81e0bf42663b448362495c403e074af96ff3e00
Submitter: Zuul
Branch: stable/rocky

commit f81e0bf42663b448362495c403e074af96ff3e00
Author: Luke Short <email address hidden>
Date: Tue Nov 12 14:17:52 2019 -0500

    Escape invalid JSON characters during deployment.

    By first quoting the JSON query, it is possible to easily pass
    it to the json_query plugin. This allows elements with special
    characters, such as a hyphen -, to be resolvable.

    Conflicts:
        tripleo_common/templates/deployments.yaml

    Change-Id: I56f3e5f96dc25f16aed585ca6678de53721071b7
    Closes-Bug: #1853321
    Signed-off-by: Luke Short <email address hidden>
    (cherry picked from commit c2a83c1cd5e8cc9cb04432e9bc8f37793c02f0c7)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/695750
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=5610fae46513f1875cd1acfb947e2b284ff10d3d
Submitter: Zuul
Branch: stable/queens

commit 5610fae46513f1875cd1acfb947e2b284ff10d3d
Author: Luke Short <email address hidden>
Date: Tue Nov 12 14:17:52 2019 -0500

    Escape invalid JSON characters during deployment.

    By first quoting the JSON query, it is possible to easily pass
    it to the json_query plugin. This allows elements with special
    characters, such as a hyphen -, to be resolvable.

    Conflicts:
        tripleo_common/templates/deployments.yaml

    Change-Id: I56f3e5f96dc25f16aed585ca6678de53721071b7
    Closes-Bug: #1853321
    Signed-off-by: Luke Short <email address hidden>
    (cherry picked from commit f81e0bf42663b448362495c403e074af96ff3e00)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 12.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 10.8.2 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 11.3.2 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common rocky-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common queens-eol release.