'update' RemovalPoliciesMode can lead to undesired results with node delete

[Rabi Mishra]

Suppose you've count=3, nodes=['0', '1', '2'], blacklist=[], policy=append

a. node delete ['0']

count=2, nodes=['1', '2'], blacklist=['0'], mode=append, *RemovalPolicies: [{"resource_list": ["0"]}]

b. node delete ['1']

count=1, nodes=['2'], blacklist=['0', '1'], mode=append, *RemovalPolicies: [{"resource_list": ["1"]}]

c. overcloud update with policy mode change to 'update' (It will use count=3 in template)

count=3, nodes=['0', '2', '3'], blacklist=['1'], mode=update, *RemovalPolicies: [{"resource_list": ["1"]}]

d. node delete ['3']

count=2, nodes=['0', '1'], blacklist=['3'], mode=update, *RemovalPolicies: [{"resource_list": ["3"]}]

both 2, 3 would be deleted and '1' would be created. This seems logical as you're only asking for 2 nodes and to flush the blacklist history.

However, we should force mode=append with 'node delete' to avoid it.

count=2, nodes=['0', '2'], blacklist=['1', '3'], mode=append, *RemovalPolicies: [{"resource_list": ["3"]}]

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/689326

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/689326
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=8f5c494150660bacd6a9560c8ce343a0af8e3427
Submitter: Zuul
Branch: master

commit 8f5c494150660bacd6a9560c8ce343a0af8e3427
Author: Rabi Mishra <email address hidden>
Date: Fri Oct 18 11:30:19 2019 +0530

    Reset *RemovalPoliciesMode for node delete

    'update' *RemovalPoliciesMode during 'node delete' can result in
    undesired behaviour as we flush the blacklist history and use
    the freshly constructed blacklist and decrease the node count.

    Change-Id: Iebd0089b6ab35c84e4f20e83f1990c1c5568017f
    Closes-Bug: #1848651

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/690590

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/690591

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/690591
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=a31748f5fb4eeddb201e09636fde052b24299f10
Submitter: Zuul
Branch: stable/stein

commit a31748f5fb4eeddb201e09636fde052b24299f10
Author: Rabi Mishra <email address hidden>
Date: Fri Oct 18 11:30:19 2019 +0530

    Reset *RemovalPoliciesMode for node delete

    'update' *RemovalPoliciesMode during 'node delete' can result in
    undesired behaviour as we flush the blacklist history and use
    the freshly constructed blacklist and decrease the node count.

    Change-Id: Iebd0089b6ab35c84e4f20e83f1990c1c5568017f
    Closes-Bug: #1848651
    (cherry picked from commit 8f5c494150660bacd6a9560c8ce343a0af8e3427)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/690590
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=9bc673fed3056614f286d39e1aa054170c8abb15
Submitter: Zuul
Branch: stable/train

commit 9bc673fed3056614f286d39e1aa054170c8abb15
Author: Rabi Mishra <email address hidden>
Date: Fri Oct 18 11:30:19 2019 +0530

    Reset *RemovalPoliciesMode for node delete

    'update' *RemovalPoliciesMode during 'node delete' can result in
    undesired behaviour as we flush the blacklist history and use
    the freshly constructed blacklist and decrease the node count.

    Change-Id: Iebd0089b6ab35c84e4f20e83f1990c1c5568017f
    Closes-Bug: #1848651
    (cherry picked from commit 8f5c494150660bacd6a9560c8ce343a0af8e3427)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/691461

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/691462

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/691461
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=99272dc643e4b4638a7b5189652d614bd5887a3f
Submitter: Zuul
Branch: stable/rocky

commit 99272dc643e4b4638a7b5189652d614bd5887a3f
Author: Rabi Mishra <email address hidden>
Date: Fri Oct 18 11:30:19 2019 +0530

    Reset *RemovalPoliciesMode for node delete

    'update' *RemovalPoliciesMode during 'node delete' can result in
    undesired behaviour as we flush the blacklist history and use
    the freshly constructed blacklist and decrease the node count.

    Change-Id: Iebd0089b6ab35c84e4f20e83f1990c1c5568017f
    Closes-Bug: #1848651
    (cherry picked from commit 8f5c494150660bacd6a9560c8ce343a0af8e3427)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/691462
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=7494548b739af53cf95f22c3135e5aec4eb49c50
Submitter: Zuul
Branch: stable/queens

commit 7494548b739af53cf95f22c3135e5aec4eb49c50
Author: Rabi Mishra <email address hidden>
Date: Fri Oct 18 11:30:19 2019 +0530

    Reset *RemovalPoliciesMode for node delete

    'update' *RemovalPoliciesMode during 'node delete' can result in
    undesired behaviour as we flush the blacklist history and use
    the freshly constructed blacklist and decrease the node count.

    Change-Id: Iebd0089b6ab35c84e4f20e83f1990c1c5568017f
    Closes-Bug: #1848651
    (cherry picked from commit 8f5c494150660bacd6a9560c8ce343a0af8e3427)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 12.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 10.8.2 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 11.3.2 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common rocky-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common queens-eol release.