tripleo

octavia config is splitting up common configuration

Bug #1836074 reported by Brent Eagles
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Carlos Goncalves
tripleo ussuri-1

Bug Description

The Octavia external deploy tasks splits up configuration that is common to some of the octavia services resulting in some of them missing some required configuration. It is probably best (and simpler) to merge them all under one common post-deployment.conf.

Orig bug: https://bugzilla.redhat.com/show_bug.cgi?id=1709925

Brent Eagles (beagles)
Changed in tripleo:
status: New → Triaged
milestone: none → train-2
assignee: nobody → Brent Eagles (beagles)
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-common (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/670085

Alex Schultz (alex-schultz)
Changed in tripleo:
milestone: train-2 → train-3
Alex Schultz (alex-schultz)
Changed in tripleo:
milestone: train-3 → ussuri-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-ansible (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/687311

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.opendev.org/687864

Changed in tripleo:
assignee: Brent Eagles (beagles) → Carlos Goncalves (cgoncalves)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-ansible (master)

Reviewed: https://review.opendev.org/687311
Committed: https://git.openstack.org/cgit/openstack/tripleo-ansible/commit/?id=a8bdaf8d55a5ec4536afe9bbc8f87acecbc1f611
Submitter: Zuul
Branch: master

commit a8bdaf8d55a5ec4536afe9bbc8f87acecbc1f611
Author: Carlos Goncalves <email address hidden>
Date: Tue Oct 8 15:18:25 2019 +0200

    Simplify octavia post deploy configs

    Octavia shares config across multiple services in sometimes unexpected
    ways. To avoid problems, this patch merges external deploy tasks
    configuration into a single file.

    Related-Bug: #1836074

    Co-Authored-By: Brent Eagles <email address hidden>
    Change-Id: I8da16dd77b77b8d81510cb1818f5d8c572080825

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-ansible (stable/train)

Related fix proposed to branch: stable/train
Review: https://review.opendev.org/689872

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-common (stable/stein)

Related fix proposed to branch: stable/stein
Review: https://review.opendev.org/689875

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.opendev.org/687864
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=c2bb9c0937852d1d5488bc727983fce3435ca898
Submitter: Zuul
Branch: master

commit c2bb9c0937852d1d5488bc727983fce3435ca898
Author: Carlos Goncalves <email address hidden>
Date: Wed Oct 9 13:47:15 2019 +0000

    Simplify octavia post deploy configs

    Consolidate post deploy configurations in a single file. Octavia
    controller services share many configurations. It is best to consolidate
    them in the same configuration file. This fixes problems seen like
    amphorae not having the controller_ip_port_list config value set on
    failover triggered by the Health Manager service as that config was only
    being loaded for the Worker service.

    Closes-Bug: #1836074
    Depends-On: https://review.opendev.org/#/c/687311/

    Change-Id: I32524f85ef6a0ca3e87fa9acc8c9e12776225717

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/690489

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-ansible (stable/train)

Reviewed: https://review.opendev.org/689872
Committed: https://git.openstack.org/cgit/openstack/tripleo-ansible/commit/?id=e00476d9cfcf517053791520c68e55aade992805
Submitter: Zuul
Branch: stable/train

commit e00476d9cfcf517053791520c68e55aade992805
Author: Carlos Goncalves <email address hidden>
Date: Tue Oct 8 15:18:25 2019 +0200

    Simplify octavia post deploy configs

    Octavia shares config across multiple services in sometimes unexpected
    ways. To avoid problems, this patch merges external deploy tasks
    configuration into a single file.

    Related-Bug: #1836074

    Co-Authored-By: Brent Eagles <email address hidden>
    Change-Id: I8da16dd77b77b8d81510cb1818f5d8c572080825
    (cherry picked from commit a8bdaf8d55a5ec4536afe9bbc8f87acecbc1f611)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/train)

Reviewed: https://review.opendev.org/690489
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=25d8177d143d7933f243543ed12cf4b956167fd1
Submitter: Zuul
Branch: stable/train

commit 25d8177d143d7933f243543ed12cf4b956167fd1
Author: Carlos Goncalves <email address hidden>
Date: Wed Oct 9 13:47:15 2019 +0000

    Simplify octavia post deploy configs

    Consolidate post deploy configurations in a single file. Octavia
    controller services share many configurations. It is best to consolidate
    them in the same configuration file. This fixes problems seen like
    amphorae not having the controller_ip_port_list config value set on
    failover triggered by the Health Manager service as that config was only
    being loaded for the Worker service.

    Closes-Bug: #1836074
    Depends-On: https://review.opendev.org/#/c/689872/

    Change-Id: I32524f85ef6a0ca3e87fa9acc8c9e12776225717
    (cherry picked from commit c2bb9c0937852d1d5488bc727983fce3435ca898)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/691825

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-common (stable/rocky)

Related fix proposed to branch: stable/rocky
Review: https://review.opendev.org/691925

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/691934

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-common (stable/queens)

Related fix proposed to branch: stable/queens
Review: https://review.opendev.org/691935

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/691936

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 12.0.0

This issue was fixed in the openstack/tripleo-heat-templates 12.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ansible (master)

Fix proposed to branch: master
Review: https://review.opendev.org/696727

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.opendev.org/696729

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ansible (master)

Reviewed: https://review.opendev.org/696727
Committed: https://git.openstack.org/cgit/openstack/tripleo-ansible/commit/?id=5f14ff39fa4d024c84cc9afce35bd499ba6d7d81
Submitter: Zuul
Branch: master

commit 5f14ff39fa4d024c84cc9afce35bd499ba6d7d81
Author: Carlos Goncalves <email address hidden>
Date: Fri Nov 29 16:55:49 2019 +0100

    Delete Octavia configuration leftovers

    Post update and upgrade tasks added in Change-Id
    I32524f85ef6a0ca3e87fa9acc8c9e12776225717 do not run as expected.
    Octavia is an external deploy. Best way to handle config leftover files
    is with an Ansible task in the end of the external deploy.

    Closes-Bug: #1836074
    Change-Id: I72e2c75ae19c6f41f2938cf165b598345b3796fc

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ansible (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/697014

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.opendev.org/696729
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=531327eec91e03c23270424b1bfc263601fb7a24
Submitter: Zuul
Branch: master

commit 531327eec91e03c23270424b1bfc263601fb7a24
Author: Carlos Goncalves <email address hidden>
Date: Fri Nov 29 17:06:19 2019 +0100

    Remove unused post update and upgrade tasks

    These tasks were incorrectly placed in post update and upgrade steps.
    They need to be moved to tripleo-ansible.
    See https://review.opendev.org/#/c/696727/

    Closes-Bug: #1836074
    Change-Id: I7da826200db1b6ac7d2a60cfa2577004d27aee17

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/697536

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/train)

Reviewed: https://review.opendev.org/697536
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=3b6f7d0575a953038432123e07cb998e94126392
Submitter: Zuul
Branch: stable/train

commit 3b6f7d0575a953038432123e07cb998e94126392
Author: Carlos Goncalves <email address hidden>
Date: Fri Nov 29 17:06:19 2019 +0100

    Remove unused post update and upgrade tasks

    These tasks were incorrectly placed in post update and upgrade steps.
    They need to be moved to tripleo-ansible.
    See https://review.opendev.org/#/c/696727/

    Closes-Bug: #1836074
    Change-Id: I7da826200db1b6ac7d2a60cfa2577004d27aee17
    (cherry picked from commit 531327eec91e03c23270424b1bfc263601fb7a24)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-common (stable/stein)

Reviewed: https://review.opendev.org/689875
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=1ecf1827d5dcacd561bd4dee65a4b772223ad63c
Submitter: Zuul
Branch: stable/stein

commit 1ecf1827d5dcacd561bd4dee65a4b772223ad63c
Author: Carlos Goncalves <email address hidden>
Date: Mon Oct 21 22:01:42 2019 +0100

    Simplify octavia post deploy configs

    Octavia shares config across multiple services in sometimes unexpected
    ways. To avoid problems, this patch merges external deploy tasks
    configuration into a single file.

    Note: this is a semantic backport of https://review.opendev.org/#/c/687311/

    Related-Bug: #1836074

    Co-Authored-By: Brent Eagles <email address hidden>
    Change-Id: I081330c28c967aa000ec89f255876d5386599a78

tags: added: in-stable-stein
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/stein)

Reviewed: https://review.opendev.org/691825
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=6a45e9b37a9664e753125526211c253dee318368
Submitter: Zuul
Branch: stable/stein

commit 6a45e9b37a9664e753125526211c253dee318368
Author: Carlos Goncalves <email address hidden>
Date: Wed Oct 9 13:47:15 2019 +0000

    Simplify octavia post deploy configs

    Consolidate post deploy configurations in a single file. Octavia
    controller services share many configurations. It is best to consolidate
    them in the same configuration file. This fixes problems seen like
    amphorae not having the controller_ip_port_list config value set on
    failover triggered by the Health Manager service as that config was only
    being loaded for the Worker service.

    Backport note: this backport also includes https://review.opendev.org/696729/
    Depends-On: https://review.opendev.org/#/c/689875/
    Closes-Bug: #1836074

    Change-Id: I32524f85ef6a0ca3e87fa9acc8c9e12776225717
    (cherry picked from commit c2bb9c0937852d1d5488bc727983fce3435ca898)
    (cherry picked from commit 25d8177d143d7933f243543ed12cf4b956167fd1)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-ansible 0.4.1

This issue was fixed in the openstack/tripleo-ansible 0.4.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 11.3.1

This issue was fixed in the openstack/tripleo-heat-templates 11.3.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-common (master)

Change abandoned by Brent Eagles (<email address hidden>) on branch: master
Review: https://review.opendev.org/670085
Reason: I think Carlos has taken care of this with https://review.opendev.org/#/c/687864/ and related patches.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-heat-templates (stable/queens)

Change abandoned by Carlos Goncalves (<email address hidden>) on branch: stable/queens
Review: https://review.opendev.org/691936

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-common (stable/rocky)

Reviewed: https://review.opendev.org/691925
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=bde1943e13f98fd65a474192710cdacb86f5fec5
Submitter: Zuul
Branch: stable/rocky

commit bde1943e13f98fd65a474192710cdacb86f5fec5
Author: Carlos Goncalves <email address hidden>
Date: Mon Oct 21 22:01:42 2019 +0100

    Simplify octavia post deploy configs

    Octavia shares config across multiple services in sometimes unexpected
    ways. To avoid problems, this patch merges external deploy tasks
    configuration into a single file.

    Note: this is a semantic backport of https://review.opendev.org/#/c/687311/

    Related-Bug: #1836074

    Co-Authored-By: Brent Eagles <email address hidden>
    Change-Id: I081330c28c967aa000ec89f255876d5386599a78
    (cherry picked from commit 1ecf1827d5dcacd561bd4dee65a4b772223ad63c)

tags: added: in-stable-rocky
tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-common (stable/queens)

Reviewed: https://review.opendev.org/691935
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=98956a9e912c7dd06d1cebc12f8079e04315f48f
Submitter: Zuul
Branch: stable/queens

commit 98956a9e912c7dd06d1cebc12f8079e04315f48f
Author: Carlos Goncalves <email address hidden>
Date: Mon Oct 21 22:01:42 2019 +0100

    Simplify octavia post deploy configs

    Octavia shares config across multiple services in sometimes unexpected
    ways. To avoid problems, this patch merges external deploy tasks
    configuration into a single file.

    Note: this is a semantic backport of https://review.opendev.org/#/c/687311/

    Related-Bug: #1836074

    Co-Authored-By: Brent Eagles <email address hidden>
    Change-Id: I081330c28c967aa000ec89f255876d5386599a78
    (cherry picked from commit 1ecf1827d5dcacd561bd4dee65a4b772223ad63c)
    (cherry picked from commit bde1943e13f98fd65a474192710cdacb86f5fec5)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/rocky)

Reviewed: https://review.opendev.org/691934
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=f2820edc79e76b22e227051e48950fb758eb9e17
Submitter: Zuul
Branch: stable/rocky

commit f2820edc79e76b22e227051e48950fb758eb9e17
Author: Carlos Goncalves <email address hidden>
Date: Wed Oct 9 13:47:15 2019 +0000

    Simplify octavia post deploy configs

    Consolidate post deploy configurations in a single file. Octavia
    controller services share many configurations. It is best to consolidate
    them in the same configuration file. This fixes problems seen like
    amphorae not having the controller_ip_port_list config value set on
    failover triggered by the Health Manager service as that config was only
    being loaded for the Worker service.

    Backport note: this backport also includes https://review.opendev.org/696729/
    Depends-On: https://review.opendev.org/#/c/691925/
    Closes-Bug: #1836074

    Change-Id: I32524f85ef6a0ca3e87fa9acc8c9e12776225717
    (cherry picked from commit c2bb9c0937852d1d5488bc727983fce3435ca898)
    (cherry picked from commit 25d8177d143d7933f243543ed12cf4b956167fd1)
    (cherry picked from commit 6a45e9b37a9664e753125526211c253dee318368)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/queens)

Reviewed: https://review.opendev.org/691936
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=ea86c43b8b6e2da1adc0569e5c963a9decee7f47
Submitter: Zuul
Branch: stable/queens

commit ea86c43b8b6e2da1adc0569e5c963a9decee7f47
Author: Carlos Goncalves <email address hidden>
Date: Wed Oct 9 13:47:15 2019 +0000

    Simplify octavia post deploy configs

    Consolidate post deploy configurations in a single file. Octavia
    controller services share many configurations. It is best to consolidate
    them in the same configuration file. This fixes problems seen like
    amphorae not having the controller_ip_port_list config value set on
    failover triggered by the Health Manager service as that config was only
    being loaded for the Worker service.

    Backport note: this backport also includes https://review.opendev.org/696729/
    Depends-On: https://review.opendev.org/#/c/691935/
    Closes-Bug: #1836074

    Change-Id: I32524f85ef6a0ca3e87fa9acc8c9e12776225717
    (cherry picked from commit c2bb9c0937852d1d5488bc727983fce3435ca898)
    (cherry picked from commit 25d8177d143d7933f243543ed12cf4b956167fd1)
    (cherry picked from commit 6a45e9b37a9664e753125526211c253dee318368)
    (cherry picked from commit 8e9b155a61151ef52383d42ed4866e0a785a10ca)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-ansible 1.1.0

This issue was fixed in the openstack/tripleo-ansible 1.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 12.1.0

This issue was fixed in the openstack/tripleo-heat-templates 12.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 11.4.0

This issue was fixed in the openstack/tripleo-heat-templates 11.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates rocky-eol

This issue was fixed in the openstack/tripleo-heat-templates rocky-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates queens-eol

This issue was fixed in the openstack/tripleo-heat-templates queens-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates stein-eol

This issue was fixed in the openstack/tripleo-heat-templates stein-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.