buildah containers build is always pushing even if flag is false

[Quique Llorente]

The buildah job has push to false but it is pushing

http://logs.openstack.org/02/648902/1/check/tripleo-build-containers-centos-7-buildah/e8c76ca/logs/build.log.txt.gz#_2019-04-01_07_11_01

Pushing 127.0.0.1:8787/tripleomaster/centos-binary-octavia-health-manager:eaf6d8d95d4f3badb071ee9e4cdf9a6652ada69b_156a4cd0 image with: sudo buildah push --tls-verify=False 127.0.0.1:8787/tripleomaster/centos-binary-octavia-health-manager:eaf6d8d95d4f3badb071ee9e4cdf9a6652ada69b_156a4cd0 docker://127.0.0.1:8787/tripleomaster/centos-binary-octavia-health-manager:eaf6d8d95d4f3badb071ee9e4cdf9a6652ada69b_156a4cd0
2019-04-01 07:11:01 | Pushing 127.0.0.1:8787/tripleomaster/centos-binary-octavia-housekeeping:eaf6d8d95d4f3badb071ee9e4cdf9a6652ada69b_156a4cd0 image with: sudo buildah push --tls-verify=False 127.0.0.1:8787/tripleomaster/centos-binary-octavia-housekeeping:eaf6d8d95d4f3badb071ee9e4cdf9a6652ada69b_156a4cd0 docker://127.0.0.1:8787/tripleomaster/centos-binary-octavia-housekeeping:eaf6d8d95d4f3badb071ee9e4cdf9a6652ada69b_156a4cd0
2019-04-01 07:11:01 | Pushing 127.0.0.1:8787/tripleomaster/centos-binary-octavia-api:eaf6d8d95d4f3badb071ee9e4cdf9a6652ada69b_156a4cd0 image with: sudo buildah push --tls-verify=False 127.0.0.1:8787/tripleomaster/centos-binary-octavia-api:eaf6d8d95d4f3badb071ee9e4cdf9a6652ada69b_156a4cd0 docker://127.0.0.1:8787/tripleomaster/centos-binary-octavia-api:eaf6d8d95d4f3badb071ee9e4cdf9a6652ada69b_156a4cd0

Possible fix https://review.openstack.org/649251

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/649250
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=635b89d2b1b3b11899117c2301532e0a886202d3
Submitter: Zuul
Branch: master

commit 635b89d2b1b3b11899117c2301532e0a886202d3
Author: Quique Llorente <email address hidden>
Date: Tue Apr 2 11:12:44 2019 +0200

    Implement push flag for buildah

    KollaBuilder is able to bypass container push we implement the same
    thing here with the container_push flag in the constructor.

    Related-Bug: #1822752

    Change-Id: I588154ad450bab13d3b20b77126d55ded5acd433

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/649251
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=c0747c0a0be91c8265ad2eb3e2c6b2f2630a1ca9
Submitter: Zuul
Branch: master

commit c0747c0a0be91c8265ad2eb3e2c6b2f2630a1ca9
Author: Quique Llorente <email address hidden>
Date: Tue Apr 2 11:12:17 2019 +0200

    Use "push" flag for buildah

    The push=False flag with use with kolla-build.conf is not working if we
    use buildah, clear example is the
    tripleo-build-containers-centos-7-buildah job, it's suppose to work like
    docker one but it's pushing too.

    Closes-Bug: #1822752

    Change-Id: I01788b3c11ac701b2cf8c151f95ccad7046532de

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 11.4.0 release.