incorrect undercloud inventory for "openstack overcloud config download"

[Steve Baker]

Since mistral has switched to using ssh for ansible playbooks[1] the "openstack overcloud config download" command has been rendering an undercloud inventory which won't work by default because it is assuming the stack user has keys set up to ssh to the tripleo-admin user.

This could be fixed by having the inventory code check to see if the current user is the mistral user, and if it is not then force the ansible connection to be local for the undercloud inventory.

[1] https://review.openstack.org/#/c/634617/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/648899

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/649459

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/649460

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/648899
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=3992262f5c58ac04166ff9f01ba900713144a073
Submitter: Zuul
Branch: master

commit 3992262f5c58ac04166ff9f01ba900713144a073
Author: Steve Baker <email address hidden>
Date: Mon Apr 1 17:04:21 2019 +1300

    Specify whether undercloud connection is ssh or local

    When the inventory is for running inside mistral, the connection to
    the undercloud must be ssh. For all other cases the connection should
    be local. This change requires the caller to explicitly say when the
    inventory is for inside mistral.

    Change-Id: Ic8cb93550546fb10c8c91796f395300cf575417d
    Partial-Bug: #1822518

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/649459
Committed: https://git.openstack.org/cgit/openstack/tripleo-validations/commit/?id=2468a5b267dead2a3e17a67e73eaa37610d728cc
Submitter: Zuul
Branch: master

commit 2468a5b267dead2a3e17a67e73eaa37610d728cc
Author: Steve Baker <email address hidden>
Date: Wed Apr 3 11:07:29 2019 +1300

    Add an --undercloud-connection argument

    This script isn't only used for local ansible inventories, it is also
    called by tripleoclient commands which then pass the generated
    inventory into mistral. This means there need to be the option of
    making the undercloud connection use ssh, since this is now what
    mistral requires.

    Change-Id: If4d877dbb144947347afe1de7a06f623d2db3941
    Partial-Bug: #1822518
    Depends-On: https://review.openstack.org/#/c/648899/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/649460
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=73cc43898cfcc8b99ce736f734fc5b514f5bc6e9
Submitter: Zuul
Branch: master

commit 73cc43898cfcc8b99ce736f734fc5b514f5bc6e9
Author: Steve Baker <email address hidden>
Date: Wed Apr 3 11:13:17 2019 +1300

    Generate inventory for mistral ssh

    All of the calls to get_tripleo_ansible_inventory will then pass this
    inventory to mistral, so the inventory entry for the undercloud needs
    to use ssh as the connection.

    Change-Id: I68ad49f103af79ab4b82b499b8620af9470f1ef9
    Closes-Bug: #1822518
    Depends-On: https://review.openstack.org/#/c/649459/

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 11.4.0 release.