Update/upgrade actions don't set DeployIdentifier, later upgrade run does nothing with some containers

[Jiří Stránský]

On update/upgrade/ffwd prepare we don't set DeployIdentifier, so during update/upgrade run we don't reexecute Paunch and the containers stay unchanged.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/619759

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/620316

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/619759
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=c907add512817363207ba8899a3cb14e122078d4
Submitter: Zuul
Branch: master

commit c907add512817363207ba8899a3cb14e122078d4
Author: Jiri Stransky <email address hidden>
Date: Fri Nov 23 16:54:10 2018 +0100

    Set DeployIdentifier on update/upgrade/ffwd prepare actions

    We have separate actions for deploy vs. upgrade prepare, because on
    upgrade prepare we don't want to trigger Ansible. DeployIdentifier was
    left out from the upgrade prepare action, which got exposed as a bug
    after we fixed --skip-deploy-identifier functionality in
    Ibab17dcaeebea65135fca4f40562109c90f36c27.

    Over time it would be good to further improve code sharing between
    `overcloud deploy` and `overcloud update/upgrade/ffwd prepare`, but
    for now we need a backportable fix so we just set DeployIdentifier in
    the upgrade prepare action.

    Additionally it turned out that we never updated the plan env via the
    UpdateStackAction as intended, which is now fixed too.

    Change-Id: Iefaff07995ae47dcef58739eaf90c4026fe255b0
    Closes-Bug: #1804858

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/620316
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=a1a0bc4699945a555ea5e6edc33c71dc8bbede8a
Submitter: Zuul
Branch: stable/rocky

commit a1a0bc4699945a555ea5e6edc33c71dc8bbede8a
Author: Jiri Stransky <email address hidden>
Date: Fri Nov 23 16:54:10 2018 +0100

    Set DeployIdentifier on update/upgrade/ffwd prepare actions

    We have separate actions for deploy vs. upgrade prepare, because on
    upgrade prepare we don't want to trigger Ansible. DeployIdentifier was
    left out from the upgrade prepare action, which got exposed as a bug
    after we fixed --skip-deploy-identifier functionality in
    Ibab17dcaeebea65135fca4f40562109c90f36c27.

    Over time it would be good to further improve code sharing between
    `overcloud deploy` and `overcloud update/upgrade/ffwd prepare`, but
    for now we need a backportable fix so we just set DeployIdentifier in
    the upgrade prepare action.

    Additionally it turned out that we never updated the plan env via the
    UpdateStackAction as intended, which is now fixed too.

    Change-Id: Iefaff07995ae47dcef58739eaf90c4026fe255b0
    Closes-Bug: #1804858
    (cherry picked from commit c907add512817363207ba8899a3cb14e122078d4)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 10.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 9.5.0 release.