Do not fail stack update for empty ceph ansible fetch directory

[John Fulton]

There are legit cases where a stack update occurs and it's normal for the tripleo backup of the ceph-ansible fetch directory to be empty. Do not fail the deployment in that case.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/619073

[John Fulton (jfulton-org)]

An example of a legitimate reason for the Swift fetch_dir container to be empty on stack update.

If a user deploys Ceph with TripleO but the ceph-ansible run fails (e.g. perhaps it wasn't installed), then verify_container_exists [1] will create a container and then later in the workflow the ceph-ansible run would fail so the container would be created but empty. If the user then took actions to make the ceph-ansible run succeed (e.g. installed ceph-ansible on the UC) then verify_container_exists would see the container exists and attempt to restore the fetch directory from it. However, because the container was empty, the tripleo.files.restore_temp_dir_from_swift action, would return an error to fail the deployment. The change in https://review.openstack.org/619073 modifies the action so that it doesn't return an error if the container is empty.

[1] https://github.com/openstack/tripleo-common/blob/814bd2cf4b4bb393cb7af1ea8587c9573c5edcef/workbooks/ceph-ansible.yaml#L76

[OpenStack Infra (hudson-openstack)]

Change abandoned by Juan Antonio Osorio Robles (<email address hidden>) on branch: master
Review: https://review.openstack.org/619073
Reason: clearing the gate

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/619073
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=e05349d55aaa9c423ec6a0f610fdb8842c0d224e
Submitter: Zuul
Branch: master

commit e05349d55aaa9c423ec6a0f610fdb8842c0d224e
Author: John Fulton <email address hidden>
Date: Tue Nov 20 14:35:46 2018 -0500

    Do not fail deploy for empty ceph ansible fetch directory

    The RestoreTempDirFromSwift action returned an error if
    the Swift container is empty which can stop a deployment.
    However there are legitimate reasons the Swift container
    could be empty for which the deployment should not be
    stopped.

    Change-Id: Ic2d9f31caaacbf1c83c4c716cd5e282c6a1953f0
    Closes-Bug: #1803609

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/619946

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/619947

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/619947
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=c4f94e31a9928a653f48cb700d54f84d4556ddbf
Submitter: Zuul
Branch: stable/queens

commit c4f94e31a9928a653f48cb700d54f84d4556ddbf
Author: John Fulton <email address hidden>
Date: Tue Nov 20 14:35:46 2018 -0500

    Do not fail deploy for empty ceph ansible fetch directory

    The RestoreTempDirFromSwift action returned an error if
    the Swift container is empty which can stop a deployment.
    However there are legitimate reasons the Swift container
    could be empty for which the deployment should not be
    stopped.

    Change-Id: Ic2d9f31caaacbf1c83c4c716cd5e282c6a1953f0
    Closes-Bug: #1803609
    (cherry picked from commit e05349d55aaa9c423ec6a0f610fdb8842c0d224e)

[OpenStack Infra (hudson-openstack)]

Change abandoned by Alex Schultz (<email address hidden>) on branch: stable/rocky
Review: https://review.openstack.org/619946
Reason: Clearing the gate. Do not retore this until being given the all clear. See http://lists.openstack.org/pipermail/openstack-discuss/2018-November/000368.html

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/619946
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=74ee6747812f4b597c0d9573d616dc4b8d7c6cc1
Submitter: Zuul
Branch: stable/rocky

commit 74ee6747812f4b597c0d9573d616dc4b8d7c6cc1
Author: John Fulton <email address hidden>
Date: Tue Nov 20 14:35:46 2018 -0500

    Do not fail deploy for empty ceph ansible fetch directory

    The RestoreTempDirFromSwift action returned an error if
    the Swift container is empty which can stop a deployment.
    However there are legitimate reasons the Swift container
    could be empty for which the deployment should not be
    stopped.

    Change-Id: Ic2d9f31caaacbf1c83c4c716cd5e282c6a1953f0
    Closes-Bug: #1803609
    (cherry picked from commit e05349d55aaa9c423ec6a0f610fdb8842c0d224e)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 10.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 8.6.7 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 9.5.0 release.