Error when tagging cinder-backup container for Pacemaker

[Emilien Macchi]

It seems like we broke scenario001 and 002 with https://review.openstack.org/#/c/614827 - where cinder-backup container isn't found when we try to push a tag for Pacemaker:

fatal: [centos-7-inap-mtl01-0000334308]: FAILED! => {"changed": true, "cmd": "docker tag 192.168.24.1:8787/tripleomaster/centos-binary-cinder-backup:current-tripleo-updated-20181105150724 192.168.24.1:8787/tripleomaster/centos-binary-cinder-backup:pcmklatest", "delta": "0:00:00.031334", "end": "2018-11-05 16:45:13.277874", "msg": "non-zero return code", "rc": 1, "start": "2018-11-05 16:45:13.246540", "stderr": "Error response from daemon: no such id: 192.168.24.1:8787/tripleomaster/centos-binary-cinder-backup:current-tripleo-updated-20181105150724", "stderr_lines": ["Error response from daemon: no such id: 192.168.24.1:8787/tripleomaster/centos-binary-cinder-backup:current-tripleo-updated-20181105150724"], "stdout": "", "stdout_lines": []}

http://logs.openstack.org/27/614827/8/check/tripleo-ci-centos-7-scenario002-multinode-oooq-container/460d4fa/logs/undercloud/var/log/extra/logstash.txt#_2018-11-05_16_45_20

[Dan Prince (dan-prince)]

One idea. I don't believe the new "Ansible tag" role does a pull before it tries to tag things. As such we are inherently relying on docker-puppet.py to pull images for us ahead of time as this runs early. This works for most services fine I think but note that docker-puppet.py optimizes the config runs and collectively runs the config generation for some services. I believe Cinder is one of them.

So the fix here might be to have the tagging operation pull the image ahead of time?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/616936

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/616936
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=7370ca76aafad52d75ab84655e7ee7c98e41002d
Submitter: Zuul
Branch: master

commit 7370ca76aafad52d75ab84655e7ee7c98e41002d
Author: Emilien Macchi <email address hidden>
Date: Fri Nov 9 08:53:09 2018 -0500

    tripleo-container-tag: pull image before tagging

    Adding a container pull before the tagging operation so we are sure that
    the image is in the local registry.

    We were relying on docker-puppet.py script to perform the pull but now
    we do the tag with Ansible, it's safer to ensure that the image is here.

    This patch runs a container pull before the container tag command.
    It works with both podman & docker since we use container_cli.

    Change-Id: Ib9d4ae9c2b415e427deb4b0cfc441febaa210f77
    Closes-Bug: #1802511

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 10.2.0 release.