tripleo

Message sending in the scale workbook is broken

Bug #1796893 reported by Dougal Matthews
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Critical
Dougal Matthews
tripleo stein-1

Bug Description

Currently if the workflow completes without error it will fail to send a message. It only sends error messages. This of course causes a new error.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (master)

Fix proposed to branch: master
Review: https://review.openstack.org/608995

Changed in tripleo:
assignee: nobody → Dougal Matthews (d0ugal)
status: Confirmed → In Progress
Bogdan Dobrelya (bogdando)
tags: added: rocky-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (master)

Reviewed: https://review.openstack.org/608995
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=c3db422b139fb9cd7cab4bd099df2af73a2ac448
Submitter: Zuul
Branch: master

commit c3db422b139fb9cd7cab4bd099df2af73a2ac448
Author: Dougal Matthews <email address hidden>
Date: Tue Oct 9 14:51:17 2018 +0100

    Default the scale status to SUCCESS

    The workflow only sets the status when there is a problem, otherwise it
    should default to SUCCESS. This regression was introduced in
    I906e0ae92bcd084f4bf6ec669d6be0f71dc7a29b, which assumed the status was
    always set when it isn't

    Closes-Bug: #1796893

    Change-Id: If4815d70cdf63f4f050589f8a267a0945e72ebdb

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/609705

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (stable/rocky)

Reviewed: https://review.openstack.org/609705
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=437ce7698f50d8e5e61cb0b42a3c2b5e4840ef95
Submitter: Zuul
Branch: stable/rocky

commit 437ce7698f50d8e5e61cb0b42a3c2b5e4840ef95
Author: Dougal Matthews <email address hidden>
Date: Tue Oct 9 14:51:17 2018 +0100

    Default the scale status to SUCCESS

    The workflow only sets the status when there is a problem, otherwise it
    should default to SUCCESS. This regression was introduced in
    I906e0ae92bcd084f4bf6ec669d6be0f71dc7a29b, which assumed the status was
    always set when it isn't

    Closes-Bug: #1796893

    Change-Id: If4815d70cdf63f4f050589f8a267a0945e72ebdb
    (cherry picked from commit c3db422b139fb9cd7cab4bd099df2af73a2ac448)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 10.1.0

This issue was fixed in the openstack/tripleo-common 10.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 9.5.0

This issue was fixed in the openstack/tripleo-common 9.5.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.