config-download: error during check mode with server deployments

Bug #1790928 reported by James Slagle
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
James Slagle

Bug Description

Run with --check:

TASK [Remove deployed file for ControllerOpenstackDeployment when previous deployment failed] ************************************************************************************************************************************
fatal: [openstack-1]: FAILED! => {"msg": "The conditional check 'previous_deployment_result.rc != 0' failed. The error was: error while evaluating conditional (previous_deployment_result.rc != 0): 'dict object' has no attribut
e 'rc'\n\nThe error appears to have been in '/home/jslagle/overcloud-config-download/ControllerOpenstack/deployments.yaml': line 117, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe of
fending line appears to be:\n\n\n- name: \"Remove deployed file for {{ item }} when previous deployment failed\"\n ^ here\nWe could be wrong, but this one looks like it might be an issue with\nmissing quotes. Always quote te
mplate expression brackets when they\nstart a value. For instance:\n\n with_items:\n - {{ foo }}\n\nShould be written as:\n\n with_items:\n - \"{{ foo }}\"\n"}

Changed in tripleo:
status: New → In Progress
importance: Undecided → High
assignee: nobody → James Slagle (james-slagle)
milestone: none → stein-1
tags: added: config-download
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (master)

Fix proposed to branch: master
Review: https://review.openstack.org/600182

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-common (master)

Change abandoned by Alex Schultz (<email address hidden>) on branch: master
Review: https://review.openstack.org/600182
Reason: http://lists.openstack.org/pipermail/openstack-dev/2018-September/135224.html

Changed in tripleo:
assignee: James Slagle (james-slagle) → Alex Schultz (alex-schultz)
Changed in tripleo:
assignee: Alex Schultz (alex-schultz) → James Slagle (james-slagle)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (master)

Reviewed: https://review.openstack.org/600182
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=ef778539e8ade6de32b5d526a3bd900c9b60c248
Submitter: Zuul
Branch: master

commit ef778539e8ade6de32b5d526a3bd900c9b60c248
Author: James Slagle <email address hidden>
Date: Wed Sep 5 14:44:28 2018 -0400

    Fix check mode for server deployments

    The task to remove the deployment status file from a previous failed
    attempt was failing during check mode since the registered variables it
    relies upon are not set. This patch updates the task to not run during
    check mode.

    Change-Id: I11b33f8fae6a7f1f96ce810495c92ad4e33ef66c
    Closes-Bug: #1790928

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/607404

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (stable/rocky)

Reviewed: https://review.openstack.org/607404
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=35112154f6e8b324573e12faa99c50ad6356b11a
Submitter: Zuul
Branch: stable/rocky

commit 35112154f6e8b324573e12faa99c50ad6356b11a
Author: James Slagle <email address hidden>
Date: Wed Sep 5 14:44:28 2018 -0400

    Fix check mode for server deployments

    The task to remove the deployment status file from a previous failed
    attempt was failing during check mode since the registered variables it
    relies upon are not set. This patch updates the task to not run during
    check mode.

    Change-Id: I11b33f8fae6a7f1f96ce810495c92ad4e33ef66c
    Closes-Bug: #1790928
    (cherry picked from commit ef778539e8ade6de32b5d526a3bd900c9b60c248)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 10.0.0

This issue was fixed in the openstack/tripleo-common 10.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 9.5.0

This issue was fixed in the openstack/tripleo-common 9.5.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.