When using NodeDataLookup [1], JSON is pasted into THT and it's possible that the user might supply invalid JSON [2]. In this scenario, the error handling of the tripleo-common workbook ceph-ansible.yaml could provide a more helpful error message. When investigating the Mistral task which failed, only a message about being unable to evaluate a YAQL expression is seen. Because this happens when JSON from node data look up is parsed, it would be more helpful to have an on-error statement in the parse_node_data_lookup task and report that the JSON from NodeDataLookup was not valid as it couldn't be parsed. This would then direct the user to update the JSON under NodeDataLookup in the THT.
[stack@b08-h02-r620 workbooks]$ mistral task-get 18d0daf2-5191-4948-93bb-9cc0b91e9f73
...
| Name | parse_node_data_lookup |
| State info | Failed to handle action completion [error=Can not evaluate YAQL expression [expression=json_parse($.node_data_lookup), error=Expecting property name enclosed in double quotes: line 1 column 3 (char 2), data={}], wf=tripleo.storage.v1.ceph-install, task=parse_node_data_lookup, action=std.noop]: |
| | YaqlEvaluationException: Can not evaluate YAQL expression [expression=json_parse($.node_data_lookup), error=Expecting property name enclosed in double quotes: line 1 column 3 (char 2), data={}] |
...
[1] https://docs.openstack.org/tripleo-docs/latest/install/advanced_deployment/node_specific_hieradata.html
[2]
parameter_defaults:
NodeDataLookup: |
{ # c05-h01-6048r is missing scsi-0:2:35:0 <--------- this comment makes the JSON invalid
"00000000-0000-0000-0000-0CC47A6EFD0C": {"devices": [
"/dev/disk/by-path/pci-0000:03:00.0-scsi-0:2:1:0",
"/dev/disk/by-path/pci-0000:03:00.0-scsi-0:2:32:0",
"/dev/disk/by-path/pci-0000:03:00.0-scsi-0:2:2:0",
"/dev/disk/by-path/pci-0000:03:00.0-scsi-0:2:3:0",
"/dev/disk/by-path/pci-0000:03:00.0-scsi-0:2:4:0",
"/dev/disk/by-path/pci-0000:03:00.0-scsi-0:2:5:0",
"/dev/disk/by-path/pci-0000:03:00.0-scsi-0:2:6:0",
"/dev/disk/by-path/pci-0000:03:00.0-scsi-0:2:33:0",
"/dev/disk/by-path/pci-0000:03:00.0-scsi-0:2:7:0",
"/dev/disk/by-path/pci-0000:03:00.0-scsi-0:2:8:0",
"/dev/disk/by-path/pci-0000:03:00.0-scsi-0:2:34:0",
"/dev/disk/by-path/pci-0000:03:00.0-scsi-0:2:9:0",
"/dev/disk/by-path/pci-0000:03:00.0-scsi-0:2:10:0",
"/dev/disk/by-path/pci-0000:03:00.0-scsi-0:2:11:0",
"/dev/disk/by-path/pci-0000:03:00.0-scsi-0:2:12:0",
"/dev/disk/by-path/pci-0000:03:00.0-scsi-0:2:13:0",
"/dev/disk/by-path/pci-0000:03:00.0-scsi-0:2:14:0",
"/dev/disk/by-path/pci-0000:03:00.0-scsi-0:2:15:0",
"/dev/disk/by-path/pci-0000:03:00.0-scsi-0:2:16:0",
"/dev/disk/by-path/pci-0000:03:00.0-scsi-0:2:17:0",
"/dev/disk/by-path/pci-0000:03:00.0-scsi-0:2:18:0",
"/dev/disk/by-path/pci-0000:03:00.0-scsi-0:2:19:0",
"/dev/disk/by-path/pci-0000:03:00.0-scsi-0:2:20:0",
"/dev/disk/by-path/pci-0000:03:00.0-scsi-0:2:21:0",
"/dev/disk/by-path/pci-0000:03:00.0-scsi-0:2:22:0",
"/dev/disk/by-path/pci-0000:03:00.0-scsi-0:2:23:0",
"/dev/disk/by-path/pci-0000:03:00.0-scsi-0:2:24:0",
"/dev/disk/by-path/pci-0000:03:00.0-scsi-0:2:25:0",
"/dev/disk/by-path/pci-0000:03:00.0-scsi-0:2:26:0",
"/dev/disk/by-path/pci-0000:03:00.0-scsi-0:2:27:0",
"/dev/disk/by-path/pci-0000:03:00.0-scsi-0:2:28:0",
"/dev/disk/by-path/pci-0000:03:00.0-scsi-0:2:29:0",
"/dev/disk/by-path/pci-0000:03:00.0-scsi-0:2:30:0",
"/dev/disk/by-path/pci-0000:03:00.0-scsi-0:2:31:0"
]
}
}
Fix proposed to branch: master
Review: https:/