config-download: Server deployments should be rerun without having to specify force=true if they previously failed

[James Slagle]

When the server pre and post deployments are run, if one fails, it will not be automatically retried since the deployed file for the deployment exists under /var/lib/heat-config/deployed.

This can be overridden by passing -e force=true to ansible-playbook, however for deployments that have previously failed, I don't think this should be required, and we should just retry them automatically.

There are scenarios where the user may fix something in the environment, and they just want to rerun ansible to see if the issue is fixed. In that case, I think we should just do the right thing and automatically retry previously failed deployments.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/554276

[James Slagle (james-slagle)]

https://review.openstack.org/#/c/554276/

[OpenStack Infra (hudson-openstack)]

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.openstack.org/554276
Reason: TO NOT RE-CHECK OR RE-APPROVE - CLEARING THE GATE NOW TO FIX A BLOCKER

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/554276
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=7b359af52a7d02a26ab72dfeac91e1b24c05135d
Submitter: Zuul
Branch: master

commit 7b359af52a7d02a26ab72dfeac91e1b24c05135d
Author: James Slagle <email address hidden>
Date: Mon Mar 19 12:10:18 2018 -0400

    Retry previously failed deployments

    Previously, when the server pre and post deployments were run, if one
    failed, it would not be automatically retried since the deployed file
    for the deployment exists under /var/lib/heat-config/deployed.

    This could be overridden by passing -e force=true to ansible-playbook,
    however for deployments that have previously failed, I don't think this
    should be required, and we should just retry them automatically.

    This new behavior more closely matches the traditional behavior with
    Heat, where a stack update would automatically attempt to reapply and
    deployment that was in a failed state.

    Change-Id: I18df88297abe7be50364233ed8f2514de6d3d434
    Closes-Bug: #1756921

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 9.0.1 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/582638

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/582638
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=c5af538d77f2db2f78399c557224f0fbfb8b3797
Submitter: Zuul
Branch: stable/queens

commit c5af538d77f2db2f78399c557224f0fbfb8b3797
Author: James Slagle <email address hidden>
Date: Mon Mar 19 12:10:18 2018 -0400

    Retry previously failed deployments

    Previously, when the server pre and post deployments were run, if one
    failed, it would not be automatically retried since the deployed file
    for the deployment exists under /var/lib/heat-config/deployed.

    This could be overridden by passing -e force=true to ansible-playbook,
    however for deployments that have previously failed, I don't think this
    should be required, and we should just retry them automatically.

    This new behavior more closely matches the traditional behavior with
    Heat, where a stack update would automatically attempt to reapply and
    deployment that was in a failed state.

    Change-Id: I18df88297abe7be50364233ed8f2514de6d3d434
    Closes-Bug: #1756921
    (cherry picked from commit 7b359af52a7d02a26ab72dfeac91e1b24c05135d)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 8.6.4 release.