tripleo

Overcloud node delete is broken after upgrade to Newton

Bug #1749636 reported by Rabi Mishra
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Rabi Mishra
tripleo rocky-1

Bug Description

While fixing bug 1641142 with https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=fbc435ce167eae2c6ac1070be47ad9065561855b, we stopped passing 'parameters' to stack update call, as we set those in 'parameter_defaults' in the plan env. However, after an upgrade to Newton the stack would still have the existing 'parameters' for 'RemovalPolicies', as we do a PATCH update (for both scale-up and node delete) and would take precedence over the parameter_defaults.

Rabi Mishra (rabi)
Changed in tripleo:
assignee: nobody → Rabi Mishra (rabi)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (master)

Fix proposed to branch: master
Review: https://review.openstack.org/544781

Changed in tripleo:
status: New → In Progress
Emilien Macchi (emilienm)
Changed in tripleo:
milestone: none → rocky-1
importance: Undecided → High
Revision history for this message
Rabi Mishra (rabi) wrote :

I think we would need to backport this to stable branches till Newton? Any reason this can not make it to queens-rc1, so that have to do one less backport?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (master)

Reviewed: https://review.openstack.org/544781
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=7213aa5669492673256db9515933bb1b8ecb4a2b
Submitter: Zuul
Branch: master

commit 7213aa5669492673256db9515933bb1b8ecb4a2b
Author: rabi <email address hidden>
Date: Thu Feb 15 10:09:54 2018 +0530

    Fix overcloud node delete after an upgrade

    In fbc435ce167eae2c6ac1070be47ad9065561855b, we stopped passing
    'parameters' to stack update call. This is backward incompatible
    as the 'parameters' set for the stack before an upgrade would take
    precedence over the ones set in 'parameter_defaults' of plan env.

    Change-Id: Ia1d823386da687154c433136bf22ae6a0291573d
    Closes-Bug: #1749636

Changed in tripleo:
status: In Progress → Fix Released
Rabi Mishra (rabi)
tags: added: pike-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/545763

Rabi Mishra (rabi)
tags: added: newton-backport-potential ocata-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/546486

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/546487

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 8.5.0

This issue was fixed in the openstack/tripleo-common 8.5.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (stable/pike)

Reviewed: https://review.openstack.org/545763
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=6bae05d5eb4692b569c7620b01b335e2236406f8
Submitter: Zuul
Branch: stable/pike

commit 6bae05d5eb4692b569c7620b01b335e2236406f8
Author: rabi <email address hidden>
Date: Thu Feb 15 10:09:54 2018 +0530

    Fix overcloud node delete after an upgrade

    In fbc435ce167eae2c6ac1070be47ad9065561855b, we stopped passing
    'parameters' to stack update call. This is backward incompatible
    as the 'parameters' set for the stack before an upgrade would take
    precedence over the ones set in 'parameter_defaults' of plan env.

    Change-Id: Ia1d823386da687154c433136bf22ae6a0291573d
    Closes-Bug: #1749636
    (cherry picked from commit 7213aa5669492673256db9515933bb1b8ecb4a2b)

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 7.6.11

This issue was fixed in the openstack/tripleo-common 7.6.11 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (stable/newton)

Reviewed: https://review.openstack.org/546487
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=eac08f6caebefd9ac3f7c956e501a562d0f19624
Submitter: Zuul
Branch: stable/newton

commit eac08f6caebefd9ac3f7c956e501a562d0f19624
Author: rabi <email address hidden>
Date: Thu Feb 15 10:09:54 2018 +0530

    Fix overcloud node delete after an upgrade

    In fbc435ce167eae2c6ac1070be47ad9065561855b, we stopped passing
    'parameters' to stack update call. This is backward incompatible
    as the 'parameters' set for the stack before an upgrade would take
    precedence over the ones set in 'parameter_defaults' of plan env.

    Change-Id: Ia1d823386da687154c433136bf22ae6a0291573d
    Closes-Bug: #1749636
    (cherry picked from commit 7213aa5669492673256db9515933bb1b8ecb4a2b)

tags: added: in-stable-newton
tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (stable/ocata)

Reviewed: https://review.openstack.org/546486
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=da974e0208359d10bcdfc78ea7502500818b87e6
Submitter: Zuul
Branch: stable/ocata

commit da974e0208359d10bcdfc78ea7502500818b87e6
Author: rabi <email address hidden>
Date: Thu Feb 15 10:09:54 2018 +0530

    Fix overcloud node delete after an upgrade

    In fbc435ce167eae2c6ac1070be47ad9065561855b, we stopped passing
    'parameters' to stack update call. This is backward incompatible
    as the 'parameters' set for the stack before an upgrade would take
    precedence over the ones set in 'parameter_defaults' of plan env.

    Change-Id: Ia1d823386da687154c433136bf22ae6a0291573d
    Closes-Bug: #1749636
    (cherry picked from commit 7213aa5669492673256db9515933bb1b8ecb4a2b)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 6.1.6

This issue was fixed in the openstack/tripleo-common 6.1.6 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 5.4.8

This issue was fixed in the openstack/tripleo-common 5.4.8 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.