config-download: fail gracefully when group:os-apply-config deployment used

[James Slagle]

config-download should fail gracefully when a deployment with group:os-apply-config is used. these are not supported by config-download currently.

additionally, the only usages of them in tripleo are deprecated. we may still encounter some with custom extraconfig resources though, so they should be handled gracefully.

[James Slagle (james-slagle)]

https://review.openstack.org/531499

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/531499

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/531499
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=f32e264f7e3d875a42ebf878723697588376d79d
Submitter: Zuul
Branch: master

commit f32e264f7e3d875a42ebf878723697588376d79d
Author: James Slagle <email address hidden>
Date: Fri Jan 5 15:58:14 2018 -0500

    Fail config-download when group:os-apply-config used

    Instead of just ignoring deployments with group:os-apply-config and
    silently not applying them, this commit updates config-download to raise
    an exception instead.

    Deployments of this type are all deprecated across TripleO anyway,
    although technically they may still work when not using config-download.
    Raising an exception early will warn uses that they need to update any
    custom deployments they may be using that still use
    group:os-apply-config.

    Change-Id: I2fb9ec3964b53d219905043a0cd9732aabbd88b2
    Closes-Bug: #1741292

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 8.4.0 release.