discover tag command fails when port is included in the image name

Bug #1735565 reported by Steve Baker
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Steve Baker

Bug Description

The following will fail when the port 5000 is included in the image path:

  openstack overcloud container image tag discover --image host:5000/foo/bar:latest --tag-from-label version-release

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (master)

Fix proposed to branch: master
Review: https://review.openstack.org/524424

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (master)

Reviewed: https://review.openstack.org/524424
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=451ba333ea37f53df4ee2db8a96b191eb463af41
Submitter: Zuul
Branch: master

commit 451ba333ea37f53df4ee2db8a96b191eb463af41
Author: Steve Baker <email address hidden>
Date: Fri Dec 1 12:05:20 2017 +1300

    Tolerate ports in tag discover

    The tag parsing assumed there would only be one colon in the path,
    which does not hold when there is a port in the registry path.

    Once again we're bitten by image names not being real URLs.

    Change-Id: Ia2d0efeaa269d61f6669b141d745ab2c1bb306da
    Closes-Bug: #1735565

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 8.2.0

This issue was fixed in the openstack/tripleo-common 8.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/525314

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (stable/pike)

Reviewed: https://review.openstack.org/525314
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=34504a22276ba65f82f033313b1c89bfb4cc47db
Submitter: Zuul
Branch: stable/pike

commit 34504a22276ba65f82f033313b1c89bfb4cc47db
Author: Steve Baker <email address hidden>
Date: Fri Dec 1 12:05:20 2017 +1300

    Tolerate ports in tag discover

    The tag parsing assumed there would only be one colon in the path,
    which does not hold when there is a port in the registry path.

    Once again we're bitten by image names not being real URLs.

    Change-Id: Ia2d0efeaa269d61f6669b141d745ab2c1bb306da
    Closes-Bug: #1735565
    (cherry picked from commit 451ba333ea37f53df4ee2db8a96b191eb463af41)

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 7.6.8

This issue was fixed in the openstack/tripleo-common 7.6.8 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.