Minor update should work without container registry file

Bug #1730687 reported by mathieu bultel
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Critical
mathieu bultel

Bug Description

The minor update command should accept to run the init minor update without specifying a new container-registry file:
$ openstack overcloud update stack --init-minor-update
You need to provide a container registry file in order to update your current containers deployed.

The expected behavior is to let the minor update running even without a container file.

Changed in tripleo:
importance: Undecided → Critical
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/518361

Changed in tripleo:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (master)

Fix proposed to branch: master
Review: https://review.openstack.org/518364

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (master)

Reviewed: https://review.openstack.org/518364
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=cae27828ec1bf81ef63b1f2b6e167c591c0254bb
Submitter: Zuul
Branch: master

commit cae27828ec1bf81ef63b1f2b6e167c591c0254bb
Author: Mathieu Bultel <email address hidden>
Date: Tue Nov 7 17:00:17 2017 +0100

    Do not update the container registry if is None

    If the variable self.container_registry is None
    then it will break, we should handle this error.

    This review is related to the LP:
    https://bugs.launchpad.net/tripleo/+bug/1730687

    Change-Id: I9266e0d143c8caa00cb615d35ac808af168b87f2
    Closes-Bug: #1730687

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (master)

Reviewed: https://review.openstack.org/518361
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=a7166208b7cdd988590bd1e3b1c1f1453d29d1e1
Submitter: Zuul
Branch: master

commit a7166208b7cdd988590bd1e3b1c1f1453d29d1e1
Author: Mathieu Bultel <email address hidden>
Date: Tue Nov 7 16:51:11 2017 +0100

    Do not failed update if no container registry is set

    When the init minor update step is run without any
    container registry file, the cli should not raise
    an exception. We should accept to run it, even if
    the container won't be update. It could be usefull
    for only run package update on the env.

    Change-Id: I73d86d1ec61b9bb6d5f4a5ea8a9bc545ac963420
    Closes-Bug: #1730687

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/519286

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/519287

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (stable/pike)

Reviewed: https://review.openstack.org/519286
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=98289bf93a67c76c6814f6d0677c63590139478d
Submitter: Zuul
Branch: stable/pike

commit 98289bf93a67c76c6814f6d0677c63590139478d
Author: Mathieu Bultel <email address hidden>
Date: Tue Nov 7 16:51:11 2017 +0100

    Do not failed update if no container registry is set

    When the init minor update step is run without any
    container registry file, the cli should not raise
    an exception. We should accept to run it, even if
    the container won't be update. It could be usefull
    for only run package update on the env.

    Change-Id: I73d86d1ec61b9bb6d5f4a5ea8a9bc545ac963420
    Closes-Bug: #1730687
    (cherry picked from commit a7166208b7cdd988590bd1e3b1c1f1453d29d1e1)

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (stable/pike)

Reviewed: https://review.openstack.org/519287
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=629fb79719fe60d359a7d5f454fdd37a2a4f0287
Submitter: Zuul
Branch: stable/pike

commit 629fb79719fe60d359a7d5f454fdd37a2a4f0287
Author: Mathieu Bultel <email address hidden>
Date: Tue Nov 7 17:00:17 2017 +0100

    Do not update the container registry if is None

    If the variable self.container_registry is None
    then it will break, we should handle this error.

    This review is related to the LP:
    https://bugs.launchpad.net/tripleo/+bug/1730687

    Change-Id: I9266e0d143c8caa00cb615d35ac808af168b87f2
    Closes-Bug: #1730687
    (cherry picked from commit cae27828ec1bf81ef63b1f2b6e167c591c0254bb)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 7.3.5

This issue was fixed in the openstack/python-tripleoclient 7.3.5 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 7.6.5

This issue was fixed in the openstack/tripleo-common 7.6.5 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 8.1.0

This issue was fixed in the openstack/python-tripleoclient 8.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 8.2.0

This issue was fixed in the openstack/tripleo-common 8.2.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.