tripleo

docker/docker-puppet.py should retry the pull

Bug #1715136 reported by Attila Fazekas
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Dan Prince
tripleo queens-1

Bug Description

docker/docker-puppet.py does a `docker pull` which can fail on temporary I/O anomalies,
please retry this command 3 times before giving up. The Retrys should be logged at warning level. ~3 sec between retries is advice.

Emilien Macchi (emilienm)
Changed in tripleo:
status: New → Triaged
milestone: none → pike-rc2
importance: Undecided → High
Emilien Macchi (emilienm)
Changed in tripleo:
milestone: pike-rc2 → queens-1
Dan Prince (dan-prince)
Changed in tripleo:
assignee: nobody → Dan Prince (dan-prince)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.openstack.org/501871

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/501871
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=d3b3361a76c2e8b188fa8e586d9fb7f3c60bb66f
Submitter: Jenkins
Branch: master

commit d3b3361a76c2e8b188fa8e586d9fb7f3c60bb66f
Author: Dan Prince <email address hidden>
Date: Thu Sep 7 16:48:28 2017 -0400

    Add a docker pull retry to docker-puppet.py

    Co-Authored-By: Ian Main <email address hidden>

    Change-Id: Iad6d38690340f4a064a4527c58ed439d91fa5188
    Closes-bug: #1715136

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/502290

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/pike)

Reviewed: https://review.openstack.org/502290
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=9a1015581d59a7a38e1bdb2ff97da1161123e05c
Submitter: Jenkins
Branch: stable/pike

commit 9a1015581d59a7a38e1bdb2ff97da1161123e05c
Author: Dan Prince <email address hidden>
Date: Thu Sep 7 16:48:28 2017 -0400

    Add a docker pull retry to docker-puppet.py

    Co-Authored-By: Ian Main <email address hidden>

    Change-Id: Iad6d38690340f4a064a4527c58ed439d91fa5188
    Closes-bug: #1715136
    (cherry picked from commit d3b3361a76c2e8b188fa8e586d9fb7f3c60bb66f)

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-common (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/505681

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 7.0.1

This issue was fixed in the openstack/tripleo-heat-templates 7.0.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-common (master)

Reviewed: https://review.openstack.org/505681
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=2ff0842fcb27af43903d1738bff26bec558c966a
Submitter: Jenkins
Branch: master

commit 2ff0842fcb27af43903d1738bff26bec558c966a
Author: Martin André <email address hidden>
Date: Wed Sep 20 17:03:26 2017 +0200

    Add retry loop for docker pull

    The prepare command also needs a retry loop for docker pull in order to
    accommodate with the not so infrequent I/O failures.

    Change-Id: I14d5ef226808e8bf2e983b74c9918ea4d61a4aa1
    Related-Bug: #1715136

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 8.0.0.0b1

This issue was fixed in the openstack/tripleo-heat-templates 8.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-common (stable/pike)

Related fix proposed to branch: stable/pike
Review: https://review.openstack.org/517305

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-common (stable/pike)

Reviewed: https://review.openstack.org/517305
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=b9fd6390777b8bcb8f2591ed31540c8c2d9d831e
Submitter: Zuul
Branch: stable/pike

commit b9fd6390777b8bcb8f2591ed31540c8c2d9d831e
Author: Martin André <email address hidden>
Date: Wed Sep 20 17:03:26 2017 +0200

    Add retry loop for docker pull

    The prepare command also needs a retry loop for docker pull in order to
    accommodate with the not so infrequent I/O failures.

    Change-Id: I14d5ef226808e8bf2e983b74c9918ea4d61a4aa1
    Related-Bug: #1715136
    (cherry picked from commit 2ff0842fcb27af43903d1738bff26bec558c966a)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.