GetParametersAction takes very long

Bug #1647301 reported by Jiri Tomasek
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Adriano Petrich

Bug Description

GetParametersAction from tripleo-common is one of the most used actions in TripleO UI and it is unfortunately also the slowest action. It takes around 15 seconds to execute but sometimes it takes much longer. This poses a huge performance bottleneck for TripleO UI.

We need to do some benchmarking on that action. There are 2 big operations happening there:
- plan files pre-processing
- heat validation

There is an idea of introducing caching of action result, but problem is that heat validation is also source of server side parameters validation. So every time parameter is updated, the cash would need to get invalidated.

Tripleo-common currently does not do heat validation on UpdateParametersAction. This needs to be added.

Ryan Brady (rbrady)
Changed in tripleo:
importance: High → Medium
Dougal Matthews (d0ugal)
Changed in tripleo:
assignee: nobody → Dougal Matthews (d0ugal)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (master)

Fix proposed to branch: master
Review: https://review.openstack.org/409096

Changed in tripleo:
status: Triaged → In Progress
Changed in tripleo:
milestone: ocata-2 → ocata-3
Changed in tripleo:
milestone: ocata-3 → ocata-rc1
Changed in tripleo:
milestone: ocata-rc1 → pike-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-common (master)

Change abandoned by Dougal Matthews (<email address hidden>) on branch: master
Review: https://review.openstack.org/409096

Changed in tripleo:
assignee: Dougal Matthews (d0ugal) → Adriano Petrich (apetrich)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (master)

Fix proposed to branch: master
Review: https://review.openstack.org/444220

Changed in tripleo:
milestone: pike-1 → pike-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (master)

Reviewed: https://review.openstack.org/444220
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=78807dff26c1e40eb41d75ee0b04be09bf7fc97a
Submitter: Jenkins
Branch: master

commit 78807dff26c1e40eb41d75ee0b04be09bf7fc97a
Author: Adriano Petrich <email address hidden>
Date: Fri Mar 10 11:06:32 2017 +0000

    add caching the GetParametersAction

    This caching in swift changes the time for the GetParametersAction from
    15s to 3s

    Added tests for plan.UpdatePlanAction as there were none there.

    Change-Id: I0b543e082a3b02a35e3e979339698ae237b32ce4
    Closes-Bug: #1647301

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 7.0.0

This issue was fixed in the openstack/tripleo-common 7.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.