Unable to add node to deployment after one node was deleted

[Jiří Stránský]

After scaling down a particular role, we cannot scale it up again. This is because the scale down parameter values are passed through via 'parameters':

http://git.openstack.org/cgit/openstack/tripleo-common/tree/tripleo_common/actions/scale.py#n99

but the subsequent scale up is using 'parameter_defaults'. The old 'parameters' values still persist in the environment, and they take precedence.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/396712

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/396712
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=fbc435ce167eae2c6ac1070be47ad9065561855b
Submitter: Jenkins
Branch: master

commit fbc435ce167eae2c6ac1070be47ad9065561855b
Author: Jiri Stransky <email address hidden>
Date: Fri Nov 11 16:46:28 2016 +0100

    Only use parameter_defaults for scaling down

    We were using parameters for scaling down but parameter_defaults for
    scaling up. The old parameters from scale-down still persisted in the
    stack and took precedence over the scaled-up parameter_defaults, so the
    scaled-up values didn't propagate.

    We already update parameter_defaults in the deployment plan in that same
    method, so all we need to do is remove the 'parameters' part.

    Change-Id: I90a195a66b15c7c9057bfb415b6a730bbd9a939c
    Closes-Bug: #1641142

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/396804

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/396804
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=17fa3aed22c040bd67a97b86c41f5d6e6ee8a94a
Submitter: Jenkins
Branch: stable/newton

commit 17fa3aed22c040bd67a97b86c41f5d6e6ee8a94a
Author: Jiri Stransky <email address hidden>
Date: Fri Nov 11 16:46:28 2016 +0100

    Only use parameter_defaults for scaling down

    We were using parameters for scaling down but parameter_defaults for
    scaling up. The old parameters from scale-down still persisted in the
    stack and took precedence over the scaled-up parameter_defaults, so the
    scaled-up values didn't propagate.

    We already update parameter_defaults in the deployment plan in that same
    method, so all we need to do is remove the 'parameters' part.

    Change-Id: I90a195a66b15c7c9057bfb415b6a730bbd9a939c
    Closes-Bug: #1641142
    (cherry picked from commit fbc435ce167eae2c6ac1070be47ad9065561855b)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 5.5.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 5.4.1 release.