tripleoclient checks and validations should be mistral actions

[James Slagle]

The checks and validations in tripleoclient prior to a deployment stack-create or stack-update should probably live in tripleo-common so they can be executed by the UI.

Unless all of that has already been reimplemented in tripleo-validations. Filing this bug anyway so it's not forgotten.

[Brad P. Crochet (brad-9)]

It does not appear that the pre-deploy validations have been implemented in tripleo-validations yet. Since tripleo-validations is currently opt-in, we do not want to lose the functionality of the existing validations in the client, so a move to tripleo-common and mistral actions makes sense as an interim step.

[Tomas Sedovic (tsedovic)]

This spec (in progress) proposes having validations in the TripleO workflows and to make them opt-out:

https://review.openstack.org/#/c/393281/

I like the suggestion in this bug, but having the spec implemented should be a pre-requisite.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/416284

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/418507

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/419506

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/416284
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=5cb5678a31c77da87c3daeb6267a4dc293130aeb
Submitter: Jenkins
Branch: master

commit 5cb5678a31c77da87c3daeb6267a4dc293130aeb
Author: Brad P. Crochet <email address hidden>
Date: Tue Jan 3 11:12:31 2017 -0500

    Add support for calling validations in deploy and introspect workflows

    Following blueprint
    https://blueprints.launchpad.net/tripleo/+spec/validations-in-workflows

    This adds support for calling the validations from the deployment and
    introspection workflows. They default to off, and can be enabled by
    passing 'True' to the run_validations parameters of these workflows.

    Currently this is just for the 'pre-inspection' and 'pre-deployment'
    validation groups. The 'post-deployment' group will be added once
    Ibbb359de8a873ee76b0e274e631307d4e4804fca lands with the ability
    for a workflow to block.

    Change-Id: I439361ae20c4e302b83870cdc06a5baa90ea683c
    Partial-Bug: #1638697

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/418507
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=f2422607a90a70eda12785cb877d5adf8bde6981
Submitter: Jenkins
Branch: master

commit f2422607a90a70eda12785cb877d5adf8bde6981
Author: Brad P. Crochet <email address hidden>
Date: Tue Jan 10 13:02:43 2017 -0500

    Add support for calling validations from deployment

    The deploy plan and overcloud deploy commands can now enable the usage
    of the additional validations that are called via workflows. The
    'overcloud deploy' command and the 'plan deploy' command adds a new
    '--run-validations' switch.

    Change-Id: Ic8f79ca3f0ffdd1d5136f1ef24913281359a7808
    Partial-Bug: #1638697
    Depends-On: I439361ae20c4e302b83870cdc06a5baa90ea683c

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/419506
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=553e46e76a167612f53d86ad8474fce5f1f35b53
Submitter: Jenkins
Branch: master

commit 553e46e76a167612f53d86ad8474fce5f1f35b53
Author: Brad P. Crochet <email address hidden>
Date: Thu Jan 12 10:05:26 2017 -0500

    Add support for calling validations from introspection

    The 'bulk introspection start' and 'overcloud node introspect' commands
    can now enable the usage of the additional validations that are called
    via workflows.
    Commands now accept a '--run-validations' switch.

    Change-Id: Ifcb30b9ceb15d82fffcda24cb98f2d03f4ded354
    Partial-Bug: #1638697
    Depends-On: I439361ae20c4e302b83870cdc06a5baa90ea683c

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/428177

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/428178

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/428225

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/429684

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/429757

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/430343

[OpenStack Infra (hudson-openstack)]

Change abandoned by Brad P. Crochet (<email address hidden>) on branch: master
Review: https://review.openstack.org/430343

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/445914

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/428177
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=bc99748ff0a001bd4872f55aaaeddd7b786b038e
Submitter: Jenkins
Branch: master

commit bc99748ff0a001bd4872f55aaaeddd7b786b038e
Author: Brad P. Crochet <email address hidden>
Date: Tue Jan 31 11:18:57 2017 -0500

    Implement check boot images as a custom action

    Adds a custom action to check the status of the boot images in glance.

    Change-Id: I3e16989a788177c4fb5b102d280d212a2c8f754b
    Partial-Bug: #1638697

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/428178
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=c33b81aa31818639fd10688f511bcac0ae7618a9
Submitter: Jenkins
Branch: master

commit c33b81aa31818639fd10688f511bcac0ae7618a9
Author: Brad P. Crochet <email address hidden>
Date: Wed Feb 1 11:11:36 2017 -0500

    Implement check flavors as a custom action

    Adds a custom action to check the flavors passed against the defined
    flavors.

    Change-Id: Ia0751ec4c63692ceda97d3845edcde1c26f9a3a8
    Partial-Bug: #1638697

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/428225
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=f6f1ac9838161c09585972e245692b402e7349b5
Submitter: Jenkins
Branch: master

commit f6f1ac9838161c09585972e245692b402e7349b5
Author: Brad P. Crochet <email address hidden>
Date: Thu Feb 2 10:47:54 2017 -0500

    Implement check ironic boot configuration as a custom action

    Add a custom action and workflow for checking the configuration of the
    available Ironic nodes.

    Change-Id: I74d1c242d0d06c5aff8f6d3533399745d6d8d9f3
    Partial-Bug: #1638697

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/429684
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=65a1e19a6da30c12eccf6db53e61d00a6e18327e
Submitter: Jenkins
Branch: master

commit 65a1e19a6da30c12eccf6db53e61d00a6e18327e
Author: Brad P. Crochet <email address hidden>
Date: Mon Feb 6 07:57:47 2017 -0500

    Implement verify profiles as a custom action

    Adds a custom action to verify the number of nodes with proper profiles
    exist in the baremetal inventory.

    Change-Id: If6460877188af4d006df5f75ab5a921b411088e2
    Partial-Bug: #1638697

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/429757
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=d4517cd9cd7093ff70c11e162b5332cf930d1bc1
Submitter: Jenkins
Branch: master

commit d4517cd9cd7093ff70c11e162b5332cf930d1bc1
Author: Brad P. Crochet <email address hidden>
Date: Mon Feb 6 11:00:37 2017 -0500

    Implement check node counts as a custom action

    Adds a custom action to check the statistics of the hypervisors and
    check the node counts of the stack.

    Change-Id: I4a0576801ffbf8d29135966d7181f277ad2f8db0
    Partial-Bug: #1638697

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/445914
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=9ae174bbaae49c6904686b40b8db1b63cc1f5cef
Submitter: Jenkins
Branch: master

commit 9ae174bbaae49c6904686b40b8db1b63cc1f5cef
Author: Brad P. Crochet <email address hidden>
Date: Wed Mar 15 08:32:19 2017 -0400

    Add workflow wrapping all predeployment checks

    This workflow wraps all of the predeployment checks so they can
    be called at once. It will report back the errors and warnings collected
    from all the checks.

    Change-Id: Ic28b91e408b957c850f631759bd4c1b4df86dba3
    Partial-Bug: #1638697

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/448057
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=094f7d4a4317e126862e9f2cb04b4916325982f0
Submitter: Jenkins
Branch: master

commit 094f7d4a4317e126862e9f2cb04b4916325982f0
Author: Brad P. Crochet <email address hidden>
Date: Tue Mar 21 08:26:03 2017 -0400

    Call pre-deployment checks in workflows

    Remove the old pre-deployment checks code that is now in a
    workflow, and call that workflow.

    Change-Id: I853309b4edec54e5c84b07b28d32f6839e4a2690
    Depends-On: Ic28b91e408b957c850f631759bd4c1b4df86dba3
    Closes-Bug: #1638697

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 7.1.0 release.