Make validation inputs configurable through Mistral

Bug #1625547 reported by Tomas Sedovic
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Gael Chamoulaud

Bug Description

A lot of the validations have some input that can be configured via Ansible environments. For example the undercloud-ram validation lets the expected RAM amount to be changed by passing `-e min_undercloud_ram_gb=...` to ansible-playbook.

This mechanism is not exposed in the Mistral worflow but it should be.

It would let the UI control certain aspects of the validations and when we run them in the CI, we could adapt these values to the ones expected in the CI (e.g. lower expected RAM and disk space values).

Tags: validations
Tomas Sedovic (tsedovic)
Changed in tripleo:
assignee: nobody → Tomas Sedovic (tsedovic)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (master)

Fix proposed to branch: master
Review: https://review.openstack.org/383763

Changed in tripleo:
status: Triaged → In Progress
Changed in tripleo:
assignee: Tomas Sedovic (tsedovic) → Gael Chamoulaud (gael-chamoulaud)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-common (master)

Change abandoned by Alex Schultz (<email address hidden>) on branch: master
Review: https://review.openstack.org/383763
Reason: Abandoning this patch per the TripleO Patch Abandonment guidelines (https://specs.openstack.org/openstack/tripleo-specs/specs/policy/patch-abandonment.html). If you wish to have this restored and cannot do so yourself, please reach out via #tripleo on freenode or the OpenStack Dev mailing list.

Revision history for this message
Juan Antonio Osorio Robles (juan-osorio-robles) wrote :

We're going to re-do the whole validation framework. So this should be part of the spec and not a bug.

Changed in tripleo:
status: In Progress → Invalid
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (master)

Fix proposed to branch: master
Review: https://review.openstack.org/644603

Changed in tripleo:
status: Invalid → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-common (master)

Change abandoned by Gael Chamoulaud (<email address hidden>) on branch: master
Review: https://review.openstack.org/383763

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (master)

Reviewed: https://review.openstack.org/644603
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=5762772fdf1d3ec70407c31f90aad41589e5efe2
Submitter: Zuul
Branch: master

commit 5762772fdf1d3ec70407c31f90aad41589e5efe2
Author: Gael Chamoulaud <email address hidden>
Date: Tue Mar 19 16:45:05 2019 +0100

    Make validation inputs configurable via Mistral

    The validations have certain values (e.g. the amount of RAM necessary
    for the undercloud node) configurable, but these were not exposed
    through Mistral.

    This adds a new `--inputs` parameter to the `run-validation` script
    which takes a path to a YAML or JSON file with the additional
    inputs (i.e. Ansible extra-args) defined.

    And the `run_validation` action now optionally takes an `inputs`
    dictionary which gets passed to `run-validation`.

    Closes-Bug: #1625547
    Implements: blueprint validation-framework
    Signed-off-by: Gael Chamoulaud <email address hidden>

    Change-Id: I8944cf7133d47869d26974fd123cd93c98425f17
    Co-authored: Tomas Sedovic <email address hidden>

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 10.6.1

This issue was fixed in the openstack/tripleo-common 10.6.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.