fix the update_capabilities action input
Bug #1608539 reported by
Jiri Tomasek
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
tripleo-common |
Fix Released
|
Undecided
|
Jeff Peeler |
Bug Description
Based on the discussion here: https:/
The environments input to UpdateCapabilit
for each of the environments from the input, the action should make sure that all enabled environments (value is true) are stored in mistral environment and any disabled environments are removed from mistral environment.
Also, block of code that takes care of fetching mistral environment is duplicated in heat_capabilities module, so it should get extracted into separate function
Changed in tripleo-common: | |
assignee: | nobody → Jeff Peeler (jpeeler-z) |
status: | New → In Progress |
To post a comment you must log in.
The tested input here is different from the 545129 paste, with slightly different quoting:
{ resource- registry- puppet. yaml": true, /puppet- pacemaker. yaml": false, /docker. yaml": false, /neutron- ml2-bigswitch. yaml": false, /neutron- ml2-cisco- n1kv.yaml" : false, /neutron- ml2-cisco- nexus-ucsm. yaml": false, /cinder- netapp- config. yaml": false, /puppet- ceph-external. yaml": false, /puppet- ceph-devel. yaml": false, /storage- environment. yaml": false, /config- debug.yaml" : false, /mongodb- nojournal. yaml": false, /overcloud- steps.yaml" : false, /network- isolation. yaml": false, /net-bond- with-vlans. yaml": false, /net-single- nic-with- vlans.yaml" : false
"container": "overcloud",
"environments": {
"overcloud-
"environments
"environments
"environments
"environments
"environments
"environments
"environments
"environments
"environments
"environments
"environments
"environments
"environments
"environments
"environments
}
}
Due to the way the code is structured with a try, except, and a return, I don't think refactoring will actually shorten the code any. If you have an example that does I can include it though.