networking-odl

Cleanup old journal entries

Bug #1567408 reported by Mike Kolesnik
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-odl
Fix Released
Undecided
Mike Kolesnik
tripleo
Fix Released
Low
Unassigned

Bug Description

Journal entries in 'completed' or 'failed' state aren't being cleaned up.

This can be a problem if there are many operations or the journal fills up over time.

Revision history for this message
Mike Kolesnik (mkolesni) wrote :

We should have a thread that cleans up completed & failed entries after a while.

5 minutes seems like a sane default to me, but I'm open to suggestions.

I'll work on it but feel free to suggest stuff before the patch hits gerrit.

Changed in networking-odl:
assignee: nobody → Mike Kolesnik (mkolesni)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-odl (master)

Reviewed: https://review.openstack.org/307171
Committed: https://git.openstack.org/cgit/openstack/networking-odl/commit/?id=fbff52b652d5ec2b7d41106f667ae8d52fd97554
Submitter: Jenkins
Branch: master

commit fbff52b652d5ec2b7d41106f667ae8d52fd97554
Author: oshvartz <email address hidden>
Date: Mon Apr 18 16:11:33 2016 +0300

    Add cleanup operation to maintenance thread

    JournalCleanup will delete "COMPLETED" rows where last_retried
    is older than "completed_rows_retention" (can be changed in ml2_odl config).

    This patch is based on the new maintenance thread infrastructure.

    Change-Id: Ifa3bda3fcbff23ed313175582d461f09a3a7971f
    Closes-Bug: #1567408

Changed in networking-odl:
status: New → Fix Released
Swapnil Kulkarni (coolsvap-deactivatedaccount)
Changed in tripleo:
status: New → In Progress
importance: Undecided → Low
assignee: nobody → Oded (oshvartz)
milestone: none → newton-2
Revision history for this message
Steven Hardy (shardy) wrote :

Any update on the tripleo part of this? Can someone describe what needs to be done and/or post a patch please?

Revision history for this message
Steven Hardy (shardy) wrote :

Bumping to n-3 as I don't see any code posted related to tripleo and it's unclear what action is needed

Changed in tripleo:
milestone: newton-2 → newton-3
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/tripleo-common 5.0.0.0b2

This issue was fixed in the openstack/tripleo-common 5.0.0.0b2 development milestone.

Steven Hardy (shardy)
Changed in tripleo:
milestone: newton-3 → ongoing
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/networking-odl 3.0.0

This issue was fixed in the openstack/networking-odl 3.0.0 release.

Revision history for this message
Emilien Macchi (emilienm) wrote :

There are no currently open reviews on this bug, changing the status back to the previous state and unassigning. If there are active reviews related to this bug, please include links in comments.

Changed in tripleo:
status: In Progress → New
assignee: Oded (oshvartz) → nobody
Revision history for this message
Alex Schultz (alex-schultz) wrote :

There appears to have been some issue related to this that was fixed in tripleo-common for newton. Closing this out.

Changed in tripleo:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.