HTTPNotFound exception updating an overcloud

[Zane Bitter]

In StackUpdateManager._resources_by_state(), we attempt to retrieve the event list for each resource in a stack. However, if there are not events for a given resource, Heat returns a 404 error (this is probably unwise, since it should be possible to distinguish between a resource that does not exist and one that has no events, but nevertheless that's what it does). We need to catch this error, otherwise we cannot update the overcloud in the cases where one or more resources have no associated events.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/272213

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/272213
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=272e7a82ade56c886d30a116cd886cfb0ba7f989
Submitter: Jenkins
Branch: master

commit 272e7a82ade56c886d30a116cd886cfb0ba7f989
Author: Zane Bitter <email address hidden>
Date: Mon Jan 25 13:15:24 2016 -0500

    Catch NotFound when listing events during updates

    Change-Id: Id7909431d75f77bbf1236d9836398143a4367b7f
    Closes-Bug: #1537857

[Thomas Herve (therve)]

For reference here's the traceback:

ERROR: No events found for resource XXXX
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/cliff/app.py", line 374, in run_subcommand
    result = cmd.run(parsed_args)
  File "/usr/lib/python2.7/site-packages/cliff/command.py", line 54, in run
    self.take_action(parsed_args)
  File "/usr/lib/python2.7/site-packages/tripleoclient/v1/overcloud_update.py", line 72, in take_action
    status, resources = update_manager.get_status()
  File "/usr/lib/python2.7/site-packages/tripleo_common/stack_update.py", line 63, in get_status
    resources = self._resources_by_state()
  File "/usr/lib/python2.7/site-packages/tripleo_common/stack_update.py", line 138, in _resources_by_state
    sort_dir='asc')
  File "/usr/lib/python2.7/site-packages/heatclient/v1/events.py", line 70, in list
    return self._list(url, 'events')
  File "/usr/lib/python2.7/site-packages/heatclient/openstack/common/apiclient/base.py", line 135, in _list
    body = self.client.get(url).json()
  File "/usr/lib/python2.7/site-packages/heatclient/common/http.py", line 278, in get
    return self.client_request("GET", url, **kwargs)
  File "/usr/lib/python2.7/site-packages/heatclient/common/http.py", line 271, in client_request
    resp, body = self.json_request(method, url, **kwargs)
  File "/usr/lib/python2.7/site-packages/heatclient/common/http.py", line 260, in json_request
    resp = self._http_request(url, method, **kwargs)
  File "/usr/lib/python2.7/site-packages/heatclient/common/http.py", line 215, in _http_request
    raise exc.from_response(resp)

[Zane Bitter (zaneb)]

It's too late to set the milestone, but for the record this was fixed in Mitaka.