pod_id in ShadowAgent has wrong string length

Bug #1691366 reported by Dongfeng Huang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Tricircle
Fix Released
Medium
Dongfeng Huang

Bug Description

pod_id in ShadowAgent is a foreign key, it has different string length from the referenced key in Pod.

in ShadowAgent, pod_id is defined as following:

pod_id = sql.Column('pod_id', sql.String(length=64),
                    sql.ForeignKey('pods.pod_id'),
                    nullable=False)

in Pod, pod_id is defined as following:

pod_id = sql.Column('pod_id', sql.String(length=36), primary_key=True)

The pod_id string length in ShadowAgent should be 36.

Changed in tricircle:
assignee: nobody → Dongfeng Huang (southeast02)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tricircle (master)

Fix proposed to branch: master
Review: https://review.openstack.org/465445

Changed in tricircle:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tricircle (master)

Reviewed: https://review.openstack.org/465445
Committed: https://git.openstack.org/cgit/openstack/tricircle/commit/?id=f39082848c2d08795b68e2156ab70e1466bc8e03
Submitter: Jenkins
Branch: master

commit f39082848c2d08795b68e2156ab70e1466bc8e03
Author: Dongfeng Huang <email address hidden>
Date: Wed May 17 16:03:38 2017 +0800

    Modify pod_id string length in ShadowAgent

    1. What is the problem
    pod_id in ShadowAgent is a foreign key, it references pod_id in Pod but
    has different string length with it.

    2. What is the solution to the problem
    Change pod_id string length to 36 in ShadowAgent to keep consistent
    with its definition in Pod.

    3. What the features need to be implemented to the Tricircle
    to realize the solution
    None.

    Change-Id: I75c7f0680e9c451a3df31d8a174007bf0a193e0f
    Closes-Bug: #1691366

Changed in tricircle:
status: In Progress → Fix Released
Chaoyi Huang (joehuang)
Changed in tricircle:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tricircle 3.3.0

This issue was fixed in the openstack/tricircle 3.3.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.