ingress rule missing after SEG sync

[Chaoyi Huang]

IPv4 ingress rule missing after security group rule sync-ed by xjob.

neutron --os-region-name=RegionOne security-group-list
+--------------------------------------+---------+----------------------------------------------------------------------+
| id | name | security_group_rules |
+--------------------------------------+---------+----------------------------------------------------------------------+
| 2faff560-008c-482e-b09b-970be49e285b | default | egress, IPv4 |
| | | egress, IPv6 |
| | | ingress, IPv4, remote_group_id: 2faff560-008c-482e-b09b-970be49e285b |
| | | ingress, IPv6, remote_group_id: 2faff560-008c-482e-b09b-970be49e285b |
| 630f9bd0-942e-4e48-ae33-343469317eed | default | egress, IPv4 |
| | | egress, IPv6 |
| | | ingress, IPv4, remote_group_id: 630f9bd0-942e-4e48-ae33-343469317eed |
| | | ingress, IPv6, remote_group_id: 630f9bd0-942e-4e48-ae33-343469317eed |
| c783bf70-9ef4-4508-937c-594ee675f570 | default | egress, IPv6 |
| | | ingress, IPv4, remote_ip_prefix: 10.0.1.0/24 |
| | | ingress, IPv4, remote_ip_prefix: 10.0.2.0/24 |
| | | ingress, IPv4, remote_ip_prefix: 163.3.124.0/24 |
| | | ingress, IPv4, remote_ip_prefix: 163.3.125.0/24 |
+--------------------------------------+---------+----------------------------------------------------------------------+

neutron --os-region-name=CentralRegion security-group-list
+--------------------------------------+---------+----------------------------------------------------------------------+
| id | name | security_group_rules |
+--------------------------------------+---------+----------------------------------------------------------------------+
| 75c9b44b-b8ad-4077-8d89-6a85243d55f7 | default | egress, IPv4 |
| | | egress, IPv6 |
| | | ingress, IPv4, remote_group_id: 75c9b44b-b8ad-4077-8d89-6a85243d55f7 |
| | | ingress, IPv6, remote_group_id: 75c9b44b-b8ad-4077-8d89-6a85243d55f7 |
| c783bf70-9ef4-4508-937c-594ee675f570 | default | egress, IPv4 |
| | | egress, IPv6 |
| | | ingress, IPv4, remote_group_id: c783bf70-9ef4-4508-937c-594ee675f570 |
| | | ingress, IPv6, remote_group_id: c783bf70-9ef4-4508-937c-594ee675f570 |
| dcf0f75d-806e-4292-8076-580aeb6db0be | default | egress, IPv4 |
| | | egress, IPv6 |
| | | ingress, IPv4, remote_group_id: dcf0f75d-806e-4292-8076-580aeb6db0be |
| | | ingress, IPv6, remote_group_id: dcf0f75d-806e-4292-8076-580aeb6db0be |
+--------------------------------------+---------+----------------------------------------------------------------------+

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/418277

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/418277
Committed: https://git.openstack.org/cgit/openstack/tricircle/commit/?id=2df0578cce19911ca4ee1b23eee617f03554a783
Submitter: Jenkins
Branch: master

commit 2df0578cce19911ca4ee1b23eee617f03554a783
Author: xiulin yin <email address hidden>
Date: Tue Jan 10 17:05:48 2017 +0800

    Fix security group rule sync

    1. What is the problem
    After security group rule sync-ed by XJob daemon, IPv4 ingress rule
    included in the DEFAULT security group is missing.

    2. What is the solution to the problem
    After checking the code, we find that the indenation in XManager is
    incorrect so XJob daemon doesn't collect the correct list of rules
    needed to be sync-ed to the local Neutron server. So the solution is
    simple, we just correct the indentation.

    3. What the features need to be implemented to the Tricircle
    No new features

    Change-Id: I981add46eb8fee8f1c025de0ba1805a8732f6cc5
    Closes-Bug: #1655271

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tricircle 3.0.0 release.