Tricircle

PEP8 failed when import i18n more than one

Bug #1646372 reported by zhangyanxian on 2016-12-01

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Tricircle	Fix Released	Undecided	zhangyanxian

Bug Description

1. What is the problem
When "from tricircle.common.i18n import _, _LE, _LI, _LW"
The pep8 failed: ./tricircle/network/central_plugin.py:50:36: H301 one import per line

2. What is the solution to the problem
i18n import in one line is a valid exception, and could be skipped in pep8 test

3. What the features need to be implemented to the Tricircle
N/A

See original description

zhangyanxian (zhang-yanxian) on 2016-12-01

Changed in tricircle:
assignee:	nobody → zhangyanxian (zhang-yanxian)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-12-01: Fix proposed to tricircle (master)

Fix proposed to branch: master
Review: https://review.openstack.org/405137

Changed in tricircle:
status:	New → In Progress

zhangyanxian (zhang-yanxian) on 2016-12-02

description:

updated

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-12-02: Change abandoned on tricircle (master)

Change abandoned by zhangyanxian (zhangyanxianmail@163.com) on branch: master
Review: https://review.openstack.org/405137
Reason: merge conflict,retry a new patch

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-12-02: Fix proposed to tricircle (master)

Fix proposed to branch: master
Review: https://review.openstack.org/405718

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-12-02: Fix merged to tricircle (master)

Reviewed: https://review.openstack.org/405718
Committed: https://git.openstack.org/cgit/openstack/tricircle/commit/?id=491fa1693fcccba7c47c5e1627367039ae34278c
Submitter: Jenkins
Branch: master

commit 491fa1693fcccba7c47c5e1627367039ae34278c
Author: zhangyanxian <zhangyanxianmail@163.com>
Date: Fri Dec 2 02:00:06 2016 +0000

PEP8 failed when import i18n more than one

    1. What is the problem
      When "from tricircle.common.i18n import _, _LE, _LI, _LW"
      The pep8 failed: ./tricircle/network/central_plugin.py:50:36:
      H301 one import per line

    2. What is the solution to the problem
      i18n import in one line is a valid exception, and could be skipped
      in pep8 test

3. What the features need to be implemented to the Tricircle
N/A

Closes-Bug: #1646372
Change-Id: I2adeab4d098ff4bbe8abb1d6645a20086ee5a1b7