Error when downloading: AttributeError: 'NoneType' object has no attribute 'repository'

Bug #394204 reported by jobu1324
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Trac-Bzr
Won't Fix
Low
Unassigned

Bug Description

Trac v0.11.4
trac-bzr r40 and r69, but not r50 (I've tried a few different versions)

Browsing to trunk gives me the option to download a "Zip Archive" of trunk. Instead of getting a download when clicking the download link, I get:

Trac detected an internal error:
AttributeError: 'NoneType' object has no attribute 'repository'

Additionally, with r50, instead of the above error, trac successfully gives me a file to download, but it is empty and called "diff-from-trunk-rtrunk,2-to-trunk-rtrunk,2.zip", leading me to believe it is a diff between r2 and r2 (repository is at r2).

Revision history for this message
Martin Wimpress  (flexiondotorg) wrote :

+1 - Just like to register a me too.

Changed in trac-bzr:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Martin von Gagern (gagern) wrote :

Some aspects of this issue are due to problems with Trac itself, which I reported as http://trac.edgewall.org/ticket/8919

In order to address this in trac-bzr alone, we'd have to change our path normalization to include a leading slash, which might possibly break a number of other views. We'd also have to implement diffs between unrelated dirs, probably by simply listing these dirs and marking all files from the source as deleted and from the destination as added. I don't have time to implement this, but if anyone wants to contribute a patch (or branch), I'll gladly consider it for inclusion.

Until then we should probably declare downloading ZIP files as unsupported. Will add a note to that effect in the next release.

Changed in trac-bzr:
importance: Medium → Low
Revision history for this message
Martin von Gagern (gagern) wrote :

The proper place to address this is Trac. I've written a patch for the upstream bug report. If you are interested in this download feature, try that patch and discuss any issues with it upstream. Won't address this in trac-bzr.

Changed in trac-bzr:
status: Confirmed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.