[patch] osutil and isdigit bugs

[Yoan Blanc]

I managed to install a trac + tracbzr on Gentoo (easy_install + manual install from here) and hit two little bugs, I bodged them, but it works now.

* osutil vs osutils
* and isdigit() called on int instead str.

[Jelmer Vernooij (jelmer)]

Thanks for the bugreport.

This patch doesn't look right. _parse_rev() should already receive a
string as its argument, and so the various conversions to strings in
your patch aren't necessary.

I've committed the typo fixes for the osutils module name.
--
Jelmer Vernooij <email address hidden> - http://samba.org/~jelmer/
Jabber: <email address hidden>

[Yoan Blanc (greut)]

Repository checkins event provider (ChangesetModule) failed:
AttributeError: 'int' object has no attribute 'isdigit'

Apparently the "rev" that _parse_rev gets is sometimes an int.

btw, I've got a strange empty changeset: "Changeset [null:]" both issues are maybe linked.

[Fran Boon (flavour)]

I just got bitten by upgrading trac-bzr & getting this error:
AttributeError: 'int' object has no attribute 'isdigit'

To workaround the issue, I moved my tree into a 'trunk' sub-folder of the repo (previously all was at the top-level)
Now all my links to changesets which were in style ',84' are broken - I need to replace with 'trunk,84'

No big issue for me as few links so far, but not good for breaking backwards compatiblity...

Many thanks for the useful tool :)

Fran.

[Yoan Blanc (greut)]

I can still get this using the vanilla version :

    Repository checkins event provider (ChangesetModule) failed:
    AttributeError: 'int' object has no attribute 'isdigit'

Do you think there is a way to write a test for that?

Cheers,

[Martin von Gagern (gagern)]

isdigit issue should be fixed by http://bazaar.launchpad.net/~trac-bzr-team/trac-bzr/trunk/revision/69.2.1

[Yoan Blanc (greut)]

Epic win, thanks!