Trying to view diffs between revisions on a single file shows revision on ALL files

[Andrew McClain]

If try to view differences between revisions on a single file (by clicking the revision id, then clicking "view changes" between the current revision of the file and the last changed reivison), I see the diffs of EVERY file that has changed between those two revisions.

Using branch bmonty-devel
trac 0.11b1
bzr 1.0.0 and 1.2.0 (happens with both)

[Martin von Gagern (gagern)]

Seems to be fixed in current trunk.

[Andrew Schulman (andrex)]

Martin, I'm not able to verify this. I just updated to trunk r77, restarted Apache, and asked for a diff for one file. I got the diff for all files. Is there something else I should be doing? Thanks, Andrew.

[Martin von Gagern (gagern)]

Could reproduce it now. Will investigate...

[Martin von Gagern (gagern)]

The attached branch should fix things for real this time, and also correct paths for branches not located at the repository root.

As the cleanup in http://bazaar.launchpad.net/~gagern/trac-bzr/bug194277/revision/80 kills quite a lot of code, I'll give people a few days to review this fix before I merge it into trunk. I'll be grateful for any testing it receives before that, though.

[Andrew Schulman (andrex)]

Confirmed: it works. Hooray! I'll continue using this branch for now to see I encounter any new problems.

Let me just add that I'm delighted that someone is working on trac-bzr again. I thought the project was dead. I'd gladly help out if I had the Python skills and knowledge of bzr, but alas I don't.

Thanks,
Andrew.

[Martin von Gagern (gagern)]

Thanks for the feedback! Testing stuff, for this fix and for anything
else, will be of considerable help to me. So you are contributing
already. :-)