New qtwebkit 5.0.2 breaks DPR settings

[Sergio Schvezov]

qtwebkit-opensource-src - 5.0.1-0ubuntu2~raring1~test3 had DPR settings working and read accordingly but the new 5.0.2 QtWebkit doesn't respect or follow that.

This affects the webbrowser-app in ubuntu touch.
Rolling back to the afforementioned webkit version fixes the issue

---

Current status: 5.0.1 webkit in use on images, resolved the problem. 5.0.2 will still need proper DPR patch readjusting to make it work.

[Timo Jyrinki (timo-jyrinki)]

The same patches are still being applied in 5.0.2, see lp:~kubuntu-packagers/kubuntu-packaging/qtwebkit-opensource-src :

http://bazaar.launchpad.net/~kubuntu-packagers/kubuntu-packaging/qtwebkit-opensource-src/view/head:/debian/patches/add_experimentalDevicePixelRatio.patch
http://bazaar.launchpad.net/~kubuntu-packagers/kubuntu-packaging/qtwebkit-opensource-src/view/head:/debian/patches/devicePixelResolution.patch

However the former patch didn't apply cleanly in one section, see http://bazaar.launchpad.net/~kubuntu-packagers/kubuntu-packaging/qtwebkit-opensource-src/revision/27 for the change. Since it's a patch to a patch it's hard to see the real changes on a LP web page though. Potentially something there would need changing / updating?

[Olivier Tilloy (osomon)]

I can confirm that the upgrade of libqt5webkit5-qmlwebkitplugin from 5.0.1-0ubuntu1 to 5.0.2-0ubuntu1~raring1~test5 breaks the DPR settings. Observed on a desktop setup (raring) with the latest webbrowser-app compiled from trunk. Before the upgrade, running `QTWEBKIT_DPR=2.0 webbrowser-app http://m.facebook.com` would have the page displayed on the left half of the window, now it’s using the full page regardless of the value of QTWEBKIT_DPR.

[Olivier Tilloy (osomon)]

Scrap the comment above, it appears that libqt5webkit5-qmlwebkitplugin 5.0.1-0ubuntu1 (from the raring archives) doesn’t have all the patches that 5.0.1 in the qt5-proper PPA has (in particular it’s missing add_experimentalDevicePixelRatio.patch).

[Timo Jyrinki (timo-jyrinki)]

The latest qtwebkit 5.0.1 build with add_experimentalDevicePixelRatio.patch and other patches is still in https://launchpad.net/~canonical-qt5-edgers/+archive/qt5-beta2/+packages

About the same patch is in the 5.0.2 package, but as explained it may need readjusting since I needed to change it slightly for it to apply on top of 5.0.2. A proper way would be to branch the packaging, take the original 5.0.1 patch from http://bazaar.launchpad.net/~kubuntu-packagers/kubuntu-packaging/qtwebkit-opensource-src/view/26/debian/patches/add_experimentalDevicePixelRatio.patch and refresh it again on top of Qt 5.0.2, probably taking some other merge decision from what I did.

[Timo Jyrinki (timo-jyrinki)]

The 5.0.2 qtwebkit was now removed from qt5-proper PPA, as it's one of those rare modules which can be apparently mixed with other versions. So 5.0.1 will be pulled from phablet PPA instead (desktop users without special PPA:s just get the raring archive version).

webkit 5.0.2 can be put back when this bug is really fixed, ie. the DPR patch updated.

[Timo Jyrinki (timo-jyrinki)]

(if we continue to stay at Qt Webkit 5.0.1 for the duration of using Qt 5.0.x stack, we can replace this bug fix by the real DPR work going to be done on top of Qt 5.1)