Incorrect inputs and outputs processing

[Denis Makogon]

Assume that there's a node with property 'auth_url' and attribute 'auth_token', then it is necessary to put them into 'outputs' section of a template:

  outputs:
    auth_token:
      value: { get_attribute: [ authorization_form, auth_token ] }
    auth_token:
      value: { get_property: [ authorization_form, auth_url ] }

But user did a mistake - he used the same name for both output items.

TOSCA parser parses in a wrong way. For item 'auth_token' it creates Output object with string value equal to '{ get_property: [ authorization_form, auth_url ] }'

This problem can be quickly overtaken by fixing output item names, and parser resolves everything correctly.

So, there are two possible ways to resolve this issue:
 - abort on parsing saying output overriding is not allowed.
 - create two Output objects with correct TOSCA functions resolving and let user deal with it.

[Sahdev Zala (spzala)]

Hi Denis, so did you see "value: { get_property: [ authorization_form, auth_url ] }" (i.e. the second value) as an output? I would vote for one of these:
1. Display the last output value? i.e. in this case, display:
    auth_token:
      value: { get_property: [ authorization_form, auth_url ] }
This is how 'OpenStack Heat' is working, that it respects last duplicated name and a similar approach should be fine for us.
2. Throw validation error that 'duplicate names are not allowed.

[Denis Makogon (lildee1991)]

Hello.

I'm fine with validation error on duplication.

Kind regards,
Denys Makogon

2016-09-12 13:05 GMT+03:00 Sahdev Zala <email address hidden>:

> Hi Denis, so did you see "value: { get_property: [ authorization_form,
> auth_url ] }" (i.e. the second value) as an output? I would vote for one of
> these:
> 1. Display the last output value? i.e. in this case, display:
> auth_token:
> value: { get_property: [ authorization_form, auth_url ] }
> This is how 'OpenStack Heat' is working, that it respects last duplicated
> name and a similar approach should be fine for us.
> 2. Throw validation error that 'duplicate names are not allowed.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1593975
>
> Title:
> Incorrect outputs processing
>
> Status in TOSCA Parser:
> In Progress
>
> Bug description:
> Assume that there's a node with property 'auth_url' and attribute
> 'auth_token', then it is necessary to put them into 'outputs' section
> of a template:
>
> outputs:
> auth_token:
> value: { get_attribute: [ authorization_form, auth_token ] }
> auth_token:
> value: { get_property: [ authorization_form, auth_url ] }
>
> But user did a mistake - he used the same name for both output items.
>
> TOSCA parser parses in a wrong way. For item 'auth_token' it creates
> Output object with string value equal to '{ get_property: [
> authorization_form, auth_url ] }'
>
> This problem can be quickly overtaken by fixing output item names, and
> parser resolves everything correctly.
>
> So, there are two possible ways to resolve this issue:
> - abort on parsing saying output overriding is not allowed.
> - create two Output objects with correct TOSCA functions resolving and
> let user deal with it.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/tosca-parser/+bug/1593975/+subscriptions
>

[Miguel Caballer (micafer1)]

Hi All,

As an user I prefer to throw validation error that 'duplicate names are not allowed. It helps to avoid errors where you do not get the expected results.

So the inputs face a similar problem, it should also throw the same validation error.

[Sahdev Zala (spzala)]

Thanks Denis and Miguel. I have changed bug subject to fail validation for duplicate inputs and outputs.