bad sync server still saves the preference

Bug #982749 reported by Olivier Bilodeau
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Status tracked in Stable
Fix Released
Fix Released

Bug Description

If you enter a wrong sync server, you get an error message (after having merged lp:~tomdroid-dev/tomdroid/rework-auth-error-handling of course) but the preference is still saved.

I tried fixing it quickly but couldn't do so in satisfying way.

We can't simply prevent the preference update because we are running things in another thread and I couldn't figure out how to have the onPreferenceChangeListener be there to get the handler's response (or if I think it made sense for it to be there for that).

I also considered resetting the old value after receiving a failure but there's all sort of race conditions where the user's URL would be overwritten and it's just sloppy in my mind..

The real fix, which is intrusive enough to be done later and not in the 0.5.1 (or whatever we'll call it) cycle, is to get the OAUTH stuff done in it's own activity, pretty much like this guy do:

So, registering the bug because it exist. Anyone interested in implementing the fix: knock yourselves out! and let us know you are working on it.

Tags: ux Edit Tag help
Olivier Bilodeau (plaxx)
Changed in tomdroid:
status: New → Confirmed
Revision history for this message
Stefan Hammer (j-4-deactivatedaccount) wrote :

Is this still needed?

Do we still plan to merge lp:~tomdroid-dev/tomdroid/rework-auth-error-handling, or do we need a new solution?

Revision history for this message
Olivier Bilodeau (plaxx) wrote : Re: [Bug 982749] Re: bad sync server still saves the preference

It depends on how error handling is implemented in the beta branch. It
could still be required.

Changed in tomdroid:
milestone: none → 0.7.3
assignee: nobody → Stefan Hammer (j-4)
status: Confirmed → Fix Committed
Changed in tomdroid:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers