Opening any kind of file suggests Tomdroid
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Tomdroid |
New
|
Undecided
|
Unassigned |
Bug Description
When Tomdroid 0.7.2 is installed, opening any file (e.g. by tapping it in OI File Manager, or after downloading an APK with F-Droid, possibly other) causes the Intent picker to come up and suggest Tomdroid among the intents for opening the file. This happens for all file types, even for those where this obviously doesn't make sense, such as APK or media files.
This behavior started after I upgraded to Tomdroid 0.7.2. I cannot reliably tell what version I was running before, most likely it was 0.7.1 (I obtained the most recent APK from f-droid.org on October 19).
Looking at the code, this behavior seems to have been introduced in revisions 418 and 460. 418 adds to AndroidManifest
460 changes the android:pathPattern to:
If I get that correctly, this intent filter is intended for note import, but matches any local file, regardless of its extension or mime type.
It would probably be better to restrict the mime type to something line text/*. For files with a missing or incorrect mime type, it may make sense to provide an alternative in the form of a pathPattern that matches some known text file extensions.
description: | updated |
This is already fixed in trunk.
Thanks for your bug report.
- stefan
Michael von Glasow <email address hidden> wrote:
>Public bug reported: .xml: name="android. intent. action. VIEW" /> name="android. intent. category. DEFAULT" /> name="android. intent. category. BROWSABLE" /> scheme= "file" /> pathPattern= ".*\\.note" /> mimeType= "*/*" pathPattern= ".*" /> .xml:
>
>When Tomdroid 0.7.2 is installed, opening any file (e.g. by tapping it
>in OI File Manager, or after downloading an APK with F-Droid, possibly
>other) causes the Intent picker to come up and suggest Tomdroid among
>the intents for opening the file. This happens for all file types, even
>for those where this obviously doesn't make sense, such as APK or media
>files.
>
>This behavior started after I upgraded to Tomdroid 0.7.2. I cannot
>reliably tell what version I was running before, most likely it was
>0.7.1 (I obtained the most recent APK from f-droid.org on October 19).
>
>Looking at the code, this behavior seems to have been introduced in
>revisions 418 and 460. 418 adds to AndroidManifest
>
> <intent-filter>
> <action android:
> <category android:
> <category android:
> <data android:
> <data android:host="*" />
> <data android:
> <data android:
> />
> </intent-filter>
>
>460 changes the android:pathPattern to:
>
> <data android:
>
>If I get that correctly, this intent filter is intended for note import,
>but matches any local file, regardless of its extension or mime type.
>
>It would probably be better to restrict the mime type to something line
>text/*. For files with a missing or incorrect mime type, it may make
>sense to provide an alternative in the form of a pathPattern that
>matches some known text file extensions.
>
>** Affects: tomdroid
> Importance: Undecided
> Status: New
>
>
>** Tags: 0.7.2 file import intent
>
>** Description changed:
>
> When Tomdroid 0.7.2 is installed, opening any file (e.g. by tapping it
> in OI File Manager, or after downloading an APK with F-Droid, possibly
>- other), the Intent picker comes up for any kind of file, suggesting to
>- open it with Tomdroid. This happens even for file types for which this
>- obviously doesn't make sense, such as APK or media files.
>+ other) causes the Intent picker to come up and suggest Tomdroid among
>+ the intents for opening the file. This happens for all file types, even
>+ for those where this obviously doesn't make sense, such as APK or media
>+ files.
>
> This behavior started after I upgraded to Tomdroid 0.7.2. I cannot
> reliably tell what version I was running before, most likely it was
> 0.7.1 (I obtained the most recent APK from f-droid.org on October 19).
>
> Looking at the code, this behavior seems to have been introduced in
> revisions 418 and 460. 418 adds to AndroidManifest
>
>- <intent-filter>
>- <action android:...