Scrolling on light theme makes list black (rev 373. By Noah)

Bug #1038633 reported by Stefan Hammer on 2012-08-19
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Tomdroid
Fix Released
Undecided
Unassigned

Bug Description

I set the option to light theme. If you then scroll the list appears black and blinks to white all the time.
Looks ugl, but I can't grab a screenshot of this.

Further, the shaddow under the Action bar is much too strong in the light theme.

It is since rev 373 in tomdroid beta branch!

Tags: ui Edit Tag help
NoahY (noahy) wrote :

I think it is the issue referred to here:

http://stackoverflow.com/questions/3782046/listview-redraws-background-color-whenever-i-scroll

I can't reproduce this on the emulator (any version) or on a tablet running 4.0.3

Can you try adding with my latest push?

Changed in tomdroid:
status: New → Incomplete

Hi!

With rev. 382 both problems still occur. List goes to black on scrolling and afterwards, Actionbar shaddow is very big.

Why do you want to have a dark and a light theme anyways?
Until Android 2.3 it was standard for most of the app to appear light, with a darker "Actionbar". This pure black theme appeared with Android 3.0. For my taste I think it is okay for Tomdroid to be light on older versions and dark for newer ones.
With the black list, it almost hurts my eyes when klicking on a note and the background changes to white.

I also think, we should avoid too many options in the preferences. I belive in minimalism when it comes to this topic.

NoahY (noahy) wrote :

I think maybe we should ask Olivier what he thinks... would it be better to have consistency across versions or consistency with Android theme choices?

Actually, I'm happy to just go with Holo.Light, which makes it all look very similar anyway. The gmail app uses Holo.Light, I think. I'll revert to that for now, as we should probably focus more on existing bugs rather than making new ones :)

Hi!

Good idea to get more opinions on this topic (as it makes the app look quite different!)

I pushed a new version, which fixed the black overlay (which was still there)
Therefore I had to remove this line: android:cacheColorHint="#000000"

Now it looks good on Android 2.3!

NoahY (noahy) wrote :

Ah sorry, I should have removed that as well. So, fixed now?

Changed in tomdroid:
status: Incomplete → Fix Committed

Yes, fixed now!

Changed in tomdroid:
milestone: none → 0.7.1
Changed in tomdroid:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers