Some access keys should be customizable

Bug #422651 reported by Angel Guzman Maeso on 2009-09-01
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Tivion
Wishlist
Angel Guzman Maeso

Bug Description

Access keys like Ctrl+Space (for pause/resume) should be customizable by interface to end-user.

Related branches

Changed in tivion:
status: Confirmed → In Progress
status: In Progress → Confirmed
Angel Guzman Maeso (shakaran) wrote :

Davide, some progress with your branch[1], but we need also a GUI for easy changes.
http://bazaar.launchpad.net/~shakaran/tivion/tivion/revision/324

Changed in tivion:
milestone: none → tivion-0.0.4
Davide Lasagna (lasagnadavide) wrote :

I think that a GUi for changing keys is not needed. Gnome already give the possibility to change accels. I fixed this bug in my branch, but there have probably been some problems with the merging.

Angel Guzman Maeso (shakaran) wrote :

A file maybe is confortable for the majority of users, but some users less advanced dont understand how to change in a file or for lazy users that only want change without read a tutorial or open a file with 15 lines. For the moment it is enough, but it can be improved.

Davide Lasagna (lasagnadavide) wrote :

Angel, there is a problem in how the menu items are created in utils.py file, in class ImageMenuItem. You can't change the accel key for all the menu items created with that class, while you can do this with the items created with gtk.Action in __do_menubar() (in tivion.py). I did some work there also to automatically load the new file where accels are saved if the user changes them, but this do not work with the current code. It worked fine, but with this new class it does no more.

Angel Guzman Maeso (shakaran) wrote :

Ok, I understand. It's complicated make a class for entrySearch and put the accels there. Maybe we need a method on Tivion class, that create the accels and then invoke that method on entrySearch. I put entrySearch on utils.py because I thought it would be better, but this is being a pain in the ass.

Davide Lasagna (lasagnadavide) wrote :

Well, i I think entrySearch class is good in utils.py, no problem with that. I'm talking about ImageMenuItem class in utils.py. I think that the whole menu thing should be done in __do_menubar method in tivion.py, so that it is possible that all items' accels can be changed as the user needs. Infact if you try changing accel for full screen (es pressing f4 when the item is selected), you'll see that you can change it but you can't with window on top. That is because the menu item is created in a different way.

Ciao

Davide

Angel Guzman Maeso (shakaran) wrote :

Defering to 0.0.5

Changed in tivion:
milestone: tivion-0.0.4 → tivion-0.0.5
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers