[Dash] Centered title should be requested by scopes explicitly and limited to one line
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu Rest Scopes |
Invalid
|
Undecided
|
Unassigned | ||
Ubuntu UX |
Invalid
|
High
|
James Mulholland | ||
timeout-scope |
Invalid
|
Undecided
|
Unassigned | ||
unity-scope-click (Ubuntu) |
Invalid
|
High
|
Unassigned | ||
unity-scope-scopes (Ubuntu) |
Invalid
|
Undecided
|
Unassigned | ||
unity8 (Ubuntu) |
Fix Released
|
High
|
Michał Sawicz |
Bug Description
When showing overlays, the title is always centered and the attributes and subtitles are left-aligned, so it looks wrong.
This screenshot shows the issue: https:/
Saviq's suggestion to fix this is to make titles always left aligned too, and to extend the category renderer so some scopes can align to the center if needed, using something like this:
{ "title" : { "field": "title", "align": "center"}, ...}
All categories that wish to have centered titles need to send the above in components, otherwise will be left-aligned.
NOTE also that this will force just a single line of title, so anything that doesn't fit in one line will be elided.
This is all according to the spec:
https:/
[UX Comment]
As suggested by Alejandro "With the latest changes to the spec and the unity8 branch there's no need for further changes in the scopes, so I'm marking the click scope as invalid for this bug."
Related branches
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
- Alejandro J. Cura (community): Needs Fixing
-
Diff: 2247 lines (+830/-318)50 files modifiedbuild.sh (+1/-0)
cmake/modules/QmlTest.cmake (+2/-1)
debian/control (+1/-0)
plugins/Dash/CardAttributes.qml (+1/-1)
plugins/Dash/CardCreator.js (+12/-10)
plugins/Dash/listviewwithpageheader.cpp (+28/-7)
plugins/Dash/listviewwithpageheader.h (+8/-0)
qml/Dash/CardGrid.qml (+2/-1)
qml/Dash/CardHorizontalList.qml (+1/-1)
qml/Dash/CardTool.qml (+27/-19)
qml/Dash/CardVerticalJournal.qml (+2/-1)
qml/Dash/DashContent.qml (+1/-0)
qml/Dash/DashRenderer.qml (+4/-0)
qml/Dash/GenericScopeView.qml (+111/-22)
qml/Dash/ScopeListView.qml (+1/-0)
qml/Dash/ScopesOverviewAll.qml (+2/-0)
qml/Dash/ScopesOverviewFavorites.qml (+1/-1)
tests/autopilot/unity8/shell/emulators/dash.py (+2/-2)
tests/mocks/Ubuntu/CMakeLists.txt (+1/-0)
tests/mocks/Ubuntu/Connectivity/CMakeLists.txt (+10/-0)
tests/mocks/Ubuntu/Connectivity/networking-status.cpp (+65/-0)
tests/mocks/Ubuntu/Connectivity/networking-status.h (+73/-0)
tests/mocks/Ubuntu/Connectivity/plugin.cpp (+46/-0)
tests/mocks/Ubuntu/Connectivity/plugin.h (+35/-0)
tests/mocks/Ubuntu/Connectivity/qmldir (+2/-0)
tests/mocks/Unity/fake_categories.cpp (+100/-141)
tests/mocks/Unity/fake_categories.h (+7/-12)
tests/mocks/Unity/fake_resultsmodel.cpp (+9/-0)
tests/mocks/Unity/fake_resultsmodel.h (+3/-0)
tests/mocks/Unity/fake_scope.cpp (+17/-0)
tests/mocks/Unity/fake_scope.h (+2/-0)
tests/plugins/Dash/CMakeLists.txt (+3/-3)
tests/plugins/Dash/cardcreator/1.res (+6/-5)
tests/plugins/Dash/cardcreator/2.res (+7/-7)
tests/plugins/Dash/cardcreator/3.res (+8/-8)
tests/plugins/Dash/cardcreator/4.res (+8/-8)
tests/plugins/Dash/cardcreator/5.res (+8/-8)
tests/plugins/Dash/cardcreator/6.res (+6/-8)
tests/plugins/Dash/cardcreator/7.res (+8/-8)
tests/plugins/Dash/listviewwithpageheadertest.cpp (+39/-0)
tests/plugins/Dash/listviewwithpageheadertest.qml (+1/-0)
tests/plugins/Dash/listviewwithpageheadertestsection.qml (+1/-0)
tests/plugins/Dash/listviewwithpageheadertestsectionexternalmodel.qml (+1/-0)
tests/plugins/Ubuntu/Gestures/CMakeLists.txt (+1/-1)
tests/qmltests/Components/CMakeLists.txt (+1/-1)
tests/qmltests/Dash/CardHelpers.js (+1/-12)
tests/qmltests/Dash/tst_Card.qml (+21/-0)
tests/qmltests/Dash/tst_CardTool.qml (+29/-21)
tests/qmltests/Dash/tst_Dash.qml (+1/-2)
tests/qmltests/Dash/tst_GenericScopeView.qml (+103/-7)
- Alejandro J. Cura (community): Approve
- Albert Astals Cid (community): Approve
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
-
Diff: 556 lines (+88/-94)16 files modifiedplugins/Dash/CardAttributes.qml (+1/-1)
plugins/Dash/CardCreator.js (+6/-7)
qml/Dash/CardGrid.qml (+1/-1)
qml/Dash/CardHorizontalList.qml (+1/-1)
qml/Dash/CardTool.qml (+19/-14)
qml/Dash/CardVerticalJournal.qml (+1/-1)
qml/Dash/ScopesOverviewFavorites.qml (+1/-1)
tests/plugins/Dash/cardcreator/1.res (+3/-3)
tests/plugins/Dash/cardcreator/2.res (+4/-5)
tests/plugins/Dash/cardcreator/3.res (+4/-5)
tests/plugins/Dash/cardcreator/4.res (+4/-5)
tests/plugins/Dash/cardcreator/5.res (+4/-5)
tests/plugins/Dash/cardcreator/6.res (+5/-7)
tests/plugins/Dash/cardcreator/7.res (+4/-5)
tests/qmltests/Dash/CardHelpers.js (+1/-12)
tests/qmltests/Dash/tst_CardTool.qml (+29/-21)
Changed in unity8 (Ubuntu): | |
status: | New → Triaged |
importance: | Undecided → High |
assignee: | nobody → Ying-Chun Liu (paulliu) |
Changed in unity8 (Ubuntu): | |
assignee: | Ying-Chun Liu (paulliu) → Michał Sawicz (saviq) |
status: | Triaged → In Progress |
tags: | added: touch-2014-09-25 |
Changed in unity-scope-click (Ubuntu): | |
status: | New → Triaged |
importance: | Undecided → High |
summary: |
- Centered title should be requested by scopes explicitly and limited to - one line + [Dash] Centered title should be requested by scopes explicitly and + limited to one line |
Changed in ubuntu-ux: | |
assignee: | nobody → James Mulholland (jamesjosephmulholland) |
Changed in ubuntu-ux: | |
status: | New → Fix Committed |
Changed in ubuntu-ux: | |
importance: | Undecided → Critical |
importance: | Critical → High |
tags: |
added: touch-2014-10-02 removed: touch-2014-09-25 |
tags: |
added: touch-2014-10-09 removed: touch-2014-10-02 |
Changed in unity-scope-scopes (Ubuntu): | |
status: | New → Invalid |
Changed in timeout-scope: | |
status: | New → Invalid |
Changed in unity8 (Ubuntu): | |
status: | In Progress → Fix Released |
description: | updated |
Changed in ubuntu-ux: | |
status: | Fix Committed → Invalid |
Remote scopes - Wikipedia is affected.