Feature Request: Ability to control Connection-Timeout from CLI

Bug #1475797 reported by G4JC
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Tickr - Feed Reader
Fix Released
Wishlist
Emmanuel Thomas-Maurin

Bug Description

Hello,
I recently came across your project and found it to be exactly what I was looking for. Unfortunately as my network sometimes requires a proxy, the feeds fail to load in time and result in an endless loop of "No HTTP Response" errors.

Unfortunately I was unable to find the source code for your latest unstable build 0.6.5 to patch against.

I was able to find 0.6.4 stable, however, and I am attaching a working patch that results in the default timeout being 60 seconds instead of 1, along with the ability to insert a custom timeout from 0-99 seconds via the newly implemented: -connection-timeout=[0-99] setting.

Might need a few tweaks, but it's mostly bug proof.

Thanks. :)

Tags: patch
Revision history for this message
G4JC (gaming4jc2) wrote :
description: updated
Revision history for this message
G4JC (gaming4jc2) wrote :

See attachment for patch.

Changed in tickr:
assignee: nobody → G4JC (gaming4jc2)
status: New → Fix Committed
Revision history for this message
Emmanuel Thomas-Maurin (manu-tm) wrote :

Hi,

Thanks for the patch. This is a useful new feature.

Version 0.6.5 is almost complete but has been delayed for months because of lack of time. Anyways, it should be available soon (ie before the end of july) and I will apply your patch.

Thanks again for your contribution.

Changed in tickr:
importance: Undecided → Wishlist
Revision history for this message
G4JC (gaming4jc2) wrote :

Cool, glad to hear the new version is on the way and you could make use of the patch!

Also if you could: Please provide SHA256 sums and a .gpg signatures for your source code hosted here: http://www.open-tickr.net/src/

Usually as simple as:
sha256sum *
gpg --default-key [your-KEY-ID] -b yoursource.tar.gz
(Brief setup tutorial: http://people.binf.ku.dk/~hanne/b2evolution/blogs/index.php/2008/10/15/gpg-signing-for-dummies)

That helps everyone avoid any server-side hacked versions and I can also get this program included in a distro that requires these.

Thanks. :)

Revision history for this message
Emmanuel Thomas-Maurin (manu-tm) wrote :

Actually, there are two select() timeouts with different default values, one for connect_to_host() and one for send_full() / recv_full(), so I'm adding 'connect-timeout' and 'sendrecv-timeout' CLI options.

I think increasing the second timeout alone should fix the 'No HTTP Response' errors, although this will need some testing.

BTW, just double-checking, is the exact error message "No HTTP Response" ? Or is it "No HTTP status code returned" ?

SHA256 checksum and gpg signature uploaded.

Changed in tickr:
assignee: G4JC (gaming4jc2) → Emmanuel Thomas-Maurin (manu-tm)
Revision history for this message
Emmanuel Thomas-Maurin (manu-tm) wrote :

Tickr version 0.7.0-3 has been released.

Changed in tickr:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers