[upstream] Adding word to dictionary doesn't update subject

[Alistair Cunningham]

When composing a new email, if you type a word that's not in the dictionary into the email subject, then type the same word in the email body, then right click on the word in the email body and select "Add to dictionary", the wavy red warning line disappears from the word in the email body, but not from the same word in the email subject.

ProblemType: Bug
DistroRelease: Ubuntu 20.10
Package: thunderbird 1:78.7.1+build1-0ubuntu0.20.10.4
ProcVersionSignature: Ubuntu 5.8.0-43.49-generic 5.8.18
Uname: Linux 5.8.0-43-generic x86_64
AddonCompatCheckDisabled: False
ApportVersion: 2.20.11-0ubuntu50.5
Architecture: amd64
AudioDevicesInUse:
 USER PID ACCESS COMMAND
 /dev/snd/controlC0: alistair 1735 F.... pulseaudio
 /dev/snd/pcmC0D0p: alistair 1735 F...m pulseaudio
BuildID: 20210203182138
CasperMD5CheckResult: skip
Channel: Unavailable
CurrentDesktop: Unity:Unity7:ubuntu
Date: Tue Feb 23 10:37:30 2021
ForcedLayersAccel: False
IfupdownConfig:
 # interfaces(5) file used by ifup(8) and ifdown(8)
 # Include files from /etc/network/interfaces.d:
 source-directory /etc/network/interfaces.d
IncompatibleExtensions:
 Lightning - {e2fda1a4-762b-4020-b5ad-a41df1933103}
 English (GB) Language Pack - <email address hidden>
 Thunderbird (default) - {972ce4c6-7e08-4474-a285-3208198ce6fd}
InstallationDate: Installed on 2020-07-14 (223 days ago)
InstallationMedia: Ubuntu 20.04 LTS "Focal Fossa" - Release amd64 (20200423)
IpRoute:
 default via 172.16.0.1 dev wlp0s20f3 proto dhcp metric 600
 10.0.0.0/24 dev wg0 proto kernel scope link src 10.0.0.2
 169.254.0.0/16 dev wg0 scope link metric 1000
 172.16.0.0/16 dev wlp0s20f3 proto kernel scope link src 172.16.69.217 metric 600
PrefErrors: Unexpected character ',' before close parenthesis @ /usr/lib/thunderbird/omni.ja:greprefs.js:732
PrefSources: prefs.js
Profiles: Profile0 (Default) - LastVersion=78.7.1/20210203182138 (In use)
RunningIncompatibleAddons: True
SourcePackage: thunderbird
UpgradeStatus: Upgraded to groovy on 2020-10-05 (141 days ago)
dmi.bios.date: 12/07/2020
dmi.bios.release: 1.15
dmi.bios.vendor: LENOVO
dmi.bios.version: N2WET25W (1.15 )
dmi.board.asset.tag: Not Available
dmi.board.name: 20U9CTO1WW
dmi.board.vendor: LENOVO
dmi.board.version: SDK0R32862 WIN
dmi.chassis.asset.tag: No Asset Information
dmi.chassis.type: 10
dmi.chassis.vendor: LENOVO
dmi.chassis.version: None
dmi.ec.firmware.release: 1.8
dmi.modalias: dmi:bvnLENOVO:bvrN2WET25W(1.15):bd12/07/2020:br1.15:efr1.8:svnLENOVO:pn20U9CTO1WW:pvrThinkPadX1CarbonGen8:rvnLENOVO:rn20U9CTO1WW:rvrSDK0R32862WIN:cvnLENOVO:ct10:cvrNone:
dmi.product.family: ThinkPad X1 Carbon Gen 8
dmi.product.name: 20U9CTO1WW
dmi.product.sku: LENOVO_MT_20U9_BU_Think_FM_ThinkPad X1 Carbon Gen 8
dmi.product.version: ThinkPad X1 Carbon Gen 8
dmi.sys.vendor: LENOVO

[Shawn-abigail (shawn-abigail)]

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.14) Gecko/20080404 Firefox/2.0.0.14
Build Identifier: version 2.0.0.14 (20080421)

If there is a word in the Subject Line of the email which is flagged as a spelling error (red line underneath) and that word also appears (and is flagged) in the body of the email, adding the word to the dictionary only unflags the word in the location where you added the word to the dictionary, but not in the other location.

Reproducible: Always

Steps to Reproduce:
1. open a new Compose window
2. type "zzv " in the Subject Line (without the quotes, but with a space). Note that the word is now flagged as a spelling error.
3. type "zzv " in the Body of the email (without the quotes, but with a space). Note that the word is now flagged as a spelling error.
4. in the Subject Line, right click on the misspelled word and select "Add to dictionary"
Actual Results:
The misspelled word is no longer flagged in the Subject Line but is still flagged in the body of the email.

Expected Results:
If a word has been added to the dictionary, both the Subject Line and the Body of the email should be scanned to unflag the word.

The error occurs whether you add the word to the dictionary from the subject line or the body of the email. System remains stable.

Note that if you go to add the word to the dictionary a second time the word is accepted. I don't know if this means that there are now two copies of the word in the dictionary, or simply that no error was reported. This is why I am reporting this bug as "Normal" instead of "Minor".

[Mkmelin+mozilla (mkmelin+mozilla)]

Confirming on linux/trunk.

xref bug 378434.

[Vseerror (vseerror)]

The behavior may have changed in current trunk - after step 4, if I touch the misspelled text in body, it is no longer underlined

This reminds me of another bug I've seen, so this may be a dupe.

[Euryalus-0 (euryalus-0)]

Confirming on

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.5pre) Gecko/20091008 Lightning/1.0pre Shredder/3.0pre ID:20091008033625

I agree to comment #1: for me is closely dupe of bug #378434

[Bugzilla2007 (bugzilla2007)]

On a related note (just dumping information), this is wrong and confusing:
1) add English words and some words from another language e.g. German to both subject and body
2) from context menu of either body or subject line, change language
3) with "spell check as you type" enabled, observe spell check error underlining in both body and subject
4) place cursor alternately in subject and body, observe spell checking markings
5) verify language setting in subject and body

Actual result:
3) immediately after changing language, it *looks* as if the other part (body vs. subject) also changes to the same language, as underlinings flip accordingly; but when you actually click into the other part (body vs. subject)...
4) ...you'll see that the underlinings flip back to the language previously active in that part, and...
5) ...language setting of the other part (body vs. subject) is NOT updated/synchronized in the menus.

Expected result:
decide what we want:
a) subject and body = single spell check area OR
b) subject and body = separate spell check areas

if a) single area: ensure synchronizing all aspects of spell checking immediately (language changes, ignored words).
if b) separate areas: ensure keeping all spell check aspects and behaviour separate (well ignored words could still go for all areas, but language changes must be either strictly separate OR sctrictly synchronized)

Current UX is really confusing.

[Alistair Cunningham (acunningham)]

This still happens on Thunderbird 91, so have reported it upstream:

https://bugzilla.mozilla.org/show_bug.cgi?id=1739405

[Vseerror (vseerror)]

*** Bug 1739405 has been marked as a duplicate of this bug. ***

[Olivier Tilloy (osomon)]

Thanks Alistair, and sorry for the initial lack of feedback.
I have linked to the upstream bug report, which is 14 years old! Sounds like no one has shown interest in addressing it in all this time :/

[Alistair Cunningham (acunningham)]

Hello Olivier,

No problem. I also reported this upstream, and it was marked as a duplicate of the old bug report.

https://bugzilla.mozilla.org/show_bug.cgi?id=1739405