Comment 52 for bug 120281

Revision history for this message
In , Andrit (andrit) wrote :

David, actually (as it is said in comment) CRLFs are just deleted. What the code does is the replace of " \r\n" with " ". I did it this was because the line

body.Replace(j, i-j + 1, ' ');

seemed to me more clear then

body.Replace(j + 1, i - j, '');

But this raise such questions then probably i was wrong and second line is more clear. What do you think?

Also one more thought: i think it would be good to check also whether wrapping is enabled at all (by analyzing wrapping length setting) and if it is not (wrapping length is 0) - do not perform this joining of lines. What do you think?

Also i noticed that even if wrapping is off (length is 0) saved mail has format=flowed and because of this it looks incorrect in preview - is this correct behavior? If one just switched off wrapping and while writing mails makes spaces at the end of some lines (say by mistake) - the mails in such a case will have format=flowed and will be looked different in preview. What do you think?

Thank you.