Importing csv file with children of existing parent gives error

[Ronald Portier (Therp)]

I have a csv files with product categories, that should be linked to the main category (the one with xml ID cat0). I try to import the csv file trough the user interface. This results in in error, saying that None can not be linked to an int.

The csv file looks like this:

id,parent_id/id,name
cat_bevestiging,product.cat0,Bevestiging
cat_elektra,product.cat0,Elektra
cat_gereedschap,product.cat0,Gereedschap

The import creates the first record (committed to the database), then returns an error, and the rest of the import fails.

So apart from the original error, there is the error that a partial import is committed.

The error occurs during computation of the parent_left, parent_right values. Because the main category, does not have parent_left or parent_right set in the database. (I think this is an error too, by the way).

The import error can be easily solved by patching one line in orm.py.

[Ronald Portier (Therp) (rportier1962)]

Improved patch, with only the changes necesarry

[Ronald Portier (Therp) (rportier1962)]

Hello Jignesh,

As far as I can see, your import links to subcategories of the main category.

But the error specifically occurs when there are no categories under the main category yet. That is when the parent_left of the main (and only) existing category will be NULL in the database, and None when retrieved through the cr cursor.

So to reproduce: start with an empty database and make sure parent left and right have not been set:

test_db=# select id, parent_left, parent_right, name, parent_id from product_category:

 id | parent_left | parent_right | name | parent_id
----+-------------+--------------+--------------+-----------
  1 | | | All products |
(1 row)

Kind regards,

Ronald