testtools.TestCase cannot be used as a parent class together with twisted.trial's TestCase

Bug #988893 reported by Guilherme Salgado
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
testtools
Fix Released
Medium
Jonathan Lange

Bug Description

testtools.TestCase provides a skip() method and trial.TestCase uses bool(getattr(test, skip)) to decide whether or not to skip, so it ends up skipping all your tests.

Since CPython renamed skip() to skipTest() for this very reason (http://bugs.python.org/issue5571), I think we should do the same in testtools.

Revision history for this message
Robert Collins (lifeless) wrote :

I agree; would appreciate a patch. Not sure what to do about compatability.

Changed in testtools:
status: New → Triaged
importance: Undecided → Wishlist
importance: Wishlist → Medium
Revision history for this message
Jonathan Lange (jml) wrote :
Changed in testtools:
status: Triaged → In Progress
assignee: nobody → Jonathan Lange (jml)
Jonathan Lange (jml)
Changed in testtools:
status: In Progress → Fix Committed
milestone: none → next
Jonathan Lange (jml)
Changed in testtools:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.